third_party/WebKit/Source/platform/fonts/TestFontSelector.h - Issue 1568433005: Platform WebUnitTestSupport onion soup: remove more indirect methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/TestFontSelector.h

Issue 1568433005: Platform WebUnitTestSupport onion soup: remove more indirect methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/TestFontSelector.h

diff --git a/third_party/WebKit/Source/platform/fonts/TestFontSelector.h b/third_party/WebKit/Source/platform/fonts/TestFontSelector.h

index 3d2bb189d9ce4a655e306a67fba99a93fe0b8d9e..6a8403f908a6537e33d163b5fb7249c973a87551 100644

--- a/third_party/WebKit/Source/platform/fonts/TestFontSelector.h

+++ b/third_party/WebKit/Source/platform/fonts/TestFontSelector.h

@@ -33,8 +33,7 @@

#include "platform/fonts/FontCustomPlatformData.h"

#include "platform/fonts/FontSelector.h"

-#include "public/platform/Platform.h"

-#include "public/platform/WebUnitTestSupport.h"

+#include "platform/testing/UnitTestHelpers.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefPtr.h"

#include "wtf/text/AtomicString.h"

@@ -45,10 +44,7 @@ class TestFontSelector : public FontSelector {

public:

static PassRefPtrWillBeRawPtr<TestFontSelector> create(const String& path)

{

- WebUnitTestSupport* unitTestSupport = Platform::current()->

- unitTestSupport();

- RefPtr<SharedBuffer> fontBuffer = static_cast<PassRefPtr<SharedBuffer>>(

- unitTestSupport->readFromFile(path));

+ RefPtr<SharedBuffer> fontBuffer = testing::readFromFile(path);

String otsParseMessage;

return adoptRefWillBeNoop(new TestFontSelector(FontCustomPlatformData::create(

fontBuffer.get(), otsParseMessage)));