third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp - Issue 1568433005: Platform WebUnitTestSupport onion soup: remove more indirect methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

Issue 1568433005: Platform WebUnitTestSupport onion soup: remove more indirect methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp ('k') | third_party/WebKit/Source/web/tests/MHTMLTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

diff --git a/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp b/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

index 14660834a6d0f2371470c29a5f40805a01a9c154..cf7e4daa945924d6f1039577941a555c42182fda 100644

--- a/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

+++ b/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

@@ -85,7 +85,7 @@ public:

if (m_client->isLoading())

Platform::current()->currentThread()->taskRunner()->postTask(BLINK_FROM_HERE, new ServeAsyncRequestsTask(m_client));

else

- Platform::current()->unitTestSupport()->exitRunLoop();

+ testing::exitRunLoop();

}

private:

@@ -95,7 +95,7 @@ private:

void pumpPendingRequests(WebFrame* frame)

{

Platform::current()->currentThread()->taskRunner()->postTask(BLINK_FROM_HERE, new ServeAsyncRequestsTask(testClientForFrame(frame)));

- Platform::current()->unitTestSupport()->enterRunLoop();

+ testing::enterRunLoop();

}

class LoadTask : public WebTaskRunner::Task {