Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 156843004: Remove ExtensionService::extension_prefs() (Closed)

Created:
6 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 10 months ago
Reviewers:
James Cook
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, estade+watch_chromium.org, benjhayden+dwatch_chromium.org, tfarina, jeremya+watch_chromium.org, haitaol+watch_chromium.org, tim+watch_chromium.org, dbeam+watch-ntp_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, rsimha+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Remove ExtensionService::extension_prefs() Callers use ExtensionPrefs::Get instead of depending on ExtensionService for access. Where appropriate, other nearby, unnecessary references to ExtensionService have also been removed. BUG=341181 TBR=benwells@chromium.org,benjhayden@chromium.org,akalin@chromium.org,pkotwicz@chromium.org,stevenjb@chromium.org,sky@chromium.org,dbeam@chromium.org,finnur@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251958

Patch Set 1 #

Patch Set 2 : additional cleanup #

Total comments: 19

Patch Set 3 : cleanup #

Patch Set 4 : rebase, format #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase. #

Patch Set 8 : rebase? #

Patch Set 9 : rebase, format, fix sync integration test compile #

Patch Set 10 : ... #

Patch Set 11 : rebase #

Patch Set 12 : one more time #

Patch Set 13 : 500 #

Patch Set 14 : 500 #

Patch Set 15 : everything in its right place #

Patch Set 16 : missed some mac code #

Patch Set 17 : Fix UserScriptListenerTests.MultiProfile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -320 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_service.cc View 9 10 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_crx_util.cc View 9 10 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/app_runtime/app_runtime_api.cc View 1 2 3 9 10 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 2 3 4 5 6 9 10 5 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 2 3 9 10 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 2 3 9 10 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 2 9 10 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api_browsertest.cc View 1 2 3 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 1 2 3 9 10 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 2 3 4 5 9 10 7 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_apitest.cc View 9 10 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/browser_action_apitest.cc View 1 9 10 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 3 9 10 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 2 3 9 10 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/data_deleter.cc View 1 2 3 9 10 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 3 9 10 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 9 10 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui_browsertest.cc View 1 2 3 9 10 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui_browsertest.cc View 9 10 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller_unittest.cc View 9 10 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 3 4 5 9 10 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 4 5 9 10 3 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 22 chunks +32 lines, -29 lines 0 comments Download
M chrome/browser/extensions/extension_util.cc View 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/install_tracker_factory.cc View 1 2 3 4 5 9 10 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 1 2 3 9 10 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/launch_util.cc View 1 2 3 9 10 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/navigation_observer.cc View 1 2 3 9 10 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 9 10 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_controller.h View 1 2 9 10 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_controller.cc View 1 2 3 4 5 9 10 4 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 1 2 3 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_app_helper.cc View 1 2 3 9 10 5 chunks +19 lines, -21 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_app_list_helper.cc View 1 9 10 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_apps_sync_test.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 9 10 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/themes/theme_syncable_service.cc View 1 2 3 9 10 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 1 2 3 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate.cc View 9 10 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 2 3 9 10 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 1 2 3 9 10 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder.cc View 1 2 3 9 10 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc View 1 2 3 4 5 9 10 4 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/recommended_apps.cc View 1 2 3 4 5 9 10 3 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 2 3 9 10 5 chunks +9 lines, -25 lines 0 comments Download
M chrome/browser/ui/extensions/extension_enable_flow.cc View 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 3 9 10 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc View 9 10 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc View 1 2 3 9 10 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_info_ui.cc View 1 2 9 10 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 5 6 7 8 9 10 7 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 3 9 10 7 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Ken Rockot(use gerrit already)
6 years, 10 months ago (2014-02-06 23:41:21 UTC) #1
James Cook
Looking good, a few little things https://codereview.chromium.org/156843004/diff/30001/chrome/browser/extensions/api/management/management_api.cc File chrome/browser/extensions/api/management/management_api.cc (right): https://codereview.chromium.org/156843004/diff/30001/chrome/browser/extensions/api/management/management_api.cc#newcode442 chrome/browser/extensions/api/management/management_api.cc:442: GetLaunchContainer(ExtensionPrefs::Get(service()->profile()), extension); Can ...
6 years, 10 months ago (2014-02-07 00:53:01 UTC) #2
Ken Rockot(use gerrit already)
woot https://codereview.chromium.org/156843004/diff/30001/chrome/browser/extensions/api/management/management_api.cc File chrome/browser/extensions/api/management/management_api.cc (right): https://codereview.chromium.org/156843004/diff/30001/chrome/browser/extensions/api/management/management_api.cc#newcode442 chrome/browser/extensions/api/management/management_api.cc:442: GetLaunchContainer(ExtensionPrefs::Get(service()->profile()), extension); On 2014/02/07 00:53:02, James Cook wrote: ...
6 years, 10 months ago (2014-02-10 18:53:01 UTC) #3
James Cook
LGTM!
6 years, 10 months ago (2014-02-10 19:48:15 UTC) #4
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 10 months ago (2014-02-18 21:20:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/156843004/730001
6 years, 10 months ago (2014-02-18 21:21:35 UTC) #6
Ken Rockot(use gerrit already)
The CQ bit was unchecked by rockot@chromium.org
6 years, 10 months ago (2014-02-18 22:09:16 UTC) #7
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 10 months ago (2014-02-18 22:16:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/156843004/720002
6 years, 10 months ago (2014-02-18 22:19:11 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 23:31:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-18 23:31:21 UTC) #11
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 10 months ago (2014-02-19 00:13:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/156843004/1190001
6 years, 10 months ago (2014-02-19 00:14:38 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 06:09:21 UTC) #14
Message was sent while issue was closed. 
Change committed as 251958

Powered by Google App Engine
This is Rietveld 408576698