chrome/browser/ui/webui/extensions/extension_info_ui.cc - Issue 156843004: Remove ExtensionService::extension_prefs()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_info_ui.cc

Issue 156843004: Remove ExtensionService::extension_prefs() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: additional cleanup Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc ('K') | « chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/webui/extensions/extension_info_ui.h"	5 #include "chrome/browser/ui/webui/extensions/extension_info_ui.h"

6	6

7 #include "base/i18n/time_formatting.h"	7 #include "base/i18n/time_formatting.h"

8 #include "base/strings/stringprintf.h"	8 #include "base/strings/stringprintf.h"

9 #include "base/strings/utf_string_conversions.h"	9 #include "base/strings/utf_string_conversions.h"

10 #include "base/time/time.h"	10 #include "base/time/time.h"

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69 source_->AddLocalizedStrings(extension_data);	69 source_->AddLocalizedStrings(extension_data);

70	70

71 // Set the icon URL.	71 // Set the icon URL.

72 GURL icon =	72 GURL icon =

73 ExtensionIconSource::GetIconURL(extension,	73 ExtensionIconSource::GetIconURL(extension,

74 extension_misc::EXTENSION_ICON_MEDIUM,	74 extension_misc::EXTENSION_ICON_MEDIUM,

75 ExtensionIconSet::MATCH_BIGGER,	75 ExtensionIconSet::MATCH_BIGGER,

76 false, NULL);	76 false, NULL);

77 source_->AddString("icon", base::UTF8ToUTF16(icon.spec()));	77 source_->AddString("icon", base::UTF8ToUTF16(icon.spec()));

78 // Set the last update time (the install time).	78 // Set the last update time (the install time).

79 base::Time install_time = extension_service->extension_prefs()->	79 base::Time install_time = ExtensionPrefs::Get(extension_service->profile())->
	James Cook 2014/02/07 00:53:02 Maybe use Profile::FromWebUI(web_ui()) like above? Maybe use Profile::FromWebUI(web_ui()) like above? Ken Rockot(use gerrit already) 2014/02/10 18:53:02 Done. Show quoted text On 2014/02/07 00:53:02, James Cook wrote: > Maybe use Profile::FromWebUI(web_ui()) like above? Done.
80 GetInstallTime(extension_id);	80 GetInstallTime(extension_id);

81 source_->AddString("installTime", base::TimeFormatShortDate(install_time));	81 source_->AddString("installTime", base::TimeFormatShortDate(install_time));

82 }	82 }

83	83

84 } // namespace extensions	84 } // namespace extensions

OLD	NEW