Remove ExtensionService::extension_prefs()

chrome/browser/ui/app_list/extension_app_item.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/extension_app_item.h"
 
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
@@ skipping 86 matching lines @@
     canvas->DrawImageInt(
         gfx::ImageSkia(masking_canvas->ExtractImageRep()), 0, 0, masking_paint);
   }
 
   gfx::ImageSkia icon_;
 
   DISALLOW_COPY_AND_ASSIGN(RoundedCornersImageSource);
 };
 
 extensions::AppSorting* GetAppSorting(Profile* profile) {
-  ExtensionService* service =
-      extensions::ExtensionSystem::Get(profile)->extension_service();
-  return service->extension_prefs()->app_sorting();
+  return extensions::ExtensionPrefs::Get(profile)->app_sorting();
 }
 
 const color_utils::HSL shift = {-1, 0, 0.6};
 
 }  // namespace
 
 ExtensionAppItem::ExtensionAppItem(
     Profile* profile,
     const app_list::AppListSyncableService::SyncItem* sync_item,
     const std::string& extension_id,
@@ skipping 28 matching lines @@
 
 bool ExtensionAppItem::NeedsOverlay() const {
   // The overlay icon is disabled for hosted apps in windowed mode with
   // streamlined hosted apps.
   bool streamlined_hosted_apps = CommandLine::ForCurrentProcess()->
       HasSwitch(switches::kEnableStreamlinedHostedApps);
 #if defined(OS_CHROMEOS)
   if (!streamlined_hosted_apps)
     return false;
 #endif
-  const ExtensionService* service =
-      extensions::ExtensionSystem::Get(profile_)->extension_service();
-
-  extensions::LaunchType launch_type = GetExtension()
-      ? extensions::GetLaunchType(service->extension_prefs(), GetExtension())
-      : extensions::LAUNCH_TYPE_WINDOW;
+  extensions::LaunchType launch_type =
+      GetExtension()
+          ? extensions::GetLaunchType(extensions::ExtensionPrefs::Get(profile_),
+                                      GetExtension())
+          : extensions::LAUNCH_TYPE_WINDOW;
 
   return !is_platform_app_ && extension_id_ != extension_misc::kChromeAppId &&
       (!streamlined_hosted_apps ||
        launch_type != extensions::LAUNCH_TYPE_WINDOW);
 }
 
 void ExtensionAppItem::Reload() {
   const Extension* extension = GetExtension();
   bool is_installing = !extension;
   SetIsInstalling(is_installing);
@@ skipping 36 matching lines @@
     UpdateIcon();
 }
 
 void ExtensionAppItem::Move(const ExtensionAppItem* prev,
                             const ExtensionAppItem* next) {
   if (!prev && !next)
     return;  // No reordering necessary
 
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile_)->extension_service();
-  extensions::AppSorting* sorting = service->extension_prefs()->app_sorting();
+  extensions::ExtensionPrefs* prefs = extensions::ExtensionPrefs::Get(profile_);
+  extensions::AppSorting* sorting = GetAppSorting(profile_);
 
   syncer::StringOrdinal page;
   std::string prev_id, next_id;
   if (!prev) {
     next_id = next->extension_id();
     page = sorting->GetPageOrdinal(next_id);
   } else if (!next) {
     prev_id = prev->extension_id();
     page = sorting->GetPageOrdinal(prev_id);
   } else {
     prev_id = prev->extension_id();
     page = sorting->GetPageOrdinal(prev_id);
     // Only set |next_id| if on the same page, otherwise just insert after prev.
     if (page.Equals(sorting->GetPageOrdinal(next->extension_id())))
       next_id = next->extension_id();
   }
-  service->extension_prefs()->SetAppDraggedByUser(extension_id_);
+  prefs->SetAppDraggedByUser(extension_id_);
   sorting->SetPageOrdinal(extension_id_, page);
   service->OnExtensionMoved(extension_id_, prev_id, next_id);
   UpdatePositionFromExtensionOrdering();
 }
 
 const Extension* ExtensionAppItem::GetExtension() const {
   const ExtensionService* service =
       extensions::ExtensionSystem::Get(profile_)->extension_service();
   const Extension* extension = service->GetInstalledExtension(extension_id_);
   return extension;
@@ skipping 105 matching lines @@
   const syncer::StringOrdinal& launch =
      GetAppSorting(profile_)->GetAppLaunchOrdinal(extension_id_);
   set_position(syncer::StringOrdinal(
       page.ToInternalValue() + launch.ToInternalValue()));
 }
 
 AppListControllerDelegate* ExtensionAppItem::GetController() {
   return AppListService::Get(chrome::GetActiveDesktop())->
       GetControllerDelegate();
 }