Remove ExtensionService::extension_prefs()

chrome/browser/extensions/api/management/management_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/management/management_api.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 107 matching lines @@
       info->type = management::ExtensionInfo::TYPE_PACKAGED_APP;
   } else if (extension.is_theme()) {
     info->type = management::ExtensionInfo::TYPE_THEME;
   } else {
     info->type = management::ExtensionInfo::TYPE_EXTENSION;
   }
 
   if (info->enabled) {
     info->disabled_reason = management::ExtensionInfo::DISABLED_REASON_NONE;
   } else {
-    ExtensionPrefs* prefs = service->extension_prefs();
+    ExtensionPrefs* prefs = ExtensionPrefs::Get(service->profile());
     if (prefs->DidExtensionEscalatePermissions(extension.id())) {
       info->disabled_reason =
           management::ExtensionInfo::DISABLED_REASON_PERMISSIONS_INCREASE;
     } else {
       info->disabled_reason =
           management::ExtensionInfo::DISABLED_REASON_UNKNOWN;
     }
   }
 
   if (!ManifestURL::GetUpdateURL(&extension).is_empty()) {
@@ skipping 293 matching lines @@
   if (!extension->is_app()) {
     error_ = ErrorUtils::FormatErrorMessage(keys::kNotAnAppError,
                                                      params->id);
     return false;
   }
 
   // Look at prefs to find the right launch container.
   // If the user has not set a preference, the default launch value will be
   // returned.
   LaunchContainer launch_container =
-      GetLaunchContainer(service()->extension_prefs(), extension);
+      GetLaunchContainer(ExtensionPrefs::Get(service()->profile()), extension);

[James Cook, 2014/02/07 00:53:02]

Can you use GetProfile() here instead of service()->profile()?

[Ken Rockot(use gerrit already), 2014/02/10 18:53:02]

Done.

   OpenApplication(AppLaunchParams(
       GetProfile(), extension, launch_container, NEW_FOREGROUND_TAB));
 #if !defined(OS_ANDROID)
   CoreAppLauncherHandler::RecordAppLaunchType(
       extension_misc::APP_LAUNCH_EXTENSION_API,
       extension->GetType());
 #endif
 
   return true;
 }
@@ skipping 24 matching lines @@
       (!params->enabled && policy->MustRemainEnabled(extension, NULL)) ||
       (params->enabled && policy->MustRemainDisabled(extension, NULL, NULL))) {
     error_ = ErrorUtils::FormatErrorMessage(
         keys::kUserCantModifyError, extension_id_);
     return false;
   }
 
   bool currently_enabled = service()->IsExtensionEnabled(extension_id_);
 
   if (!currently_enabled && params->enabled) {
-    ExtensionPrefs* prefs = service()->extension_prefs();
+    ExtensionPrefs* prefs = ExtensionPrefs::Get(service()->profile());

[James Cook, 2014/02/07 00:53:02]

ditto

[Ken Rockot(use gerrit already), 2014/02/10 18:53:02]

Done.

     if (prefs->DidExtensionEscalatePermissions(extension_id_)) {
       if (!user_gesture()) {
         error_ = keys::kGestureNeededForEscalationError;
         return false;
       }
       AddRef(); // Matched in InstallUIProceed/InstallUIAbort
       install_prompt_.reset(
           new ExtensionInstallPrompt(GetAssociatedWebContents()));
       install_prompt_->ConfirmReEnable(this, extension);
       return true;
@@ skipping 238 matching lines @@
 ProfileKeyedAPIFactory<ManagementAPI>* ManagementAPI::GetFactoryInstance() {
   return g_factory.Pointer();
 }
 
 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) {
   management_event_router_.reset(new ManagementEventRouter(profile_));
   ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this);
 }
 
 }  // namespace extensions