Update tools/perf to use cloud_storage from catapult.

Update tools/perf to use cloud_storage from catapult.

This is part of the migration work needed before we can remove the version
in telemetry.

BUG=565604
Committed: https://crrev.com/052022a2e262ed58a4cabd4b1f01aa22e4b09245
Cr-Commit-Position: refs/heads/master@{#370427}

[aiolos (Not reviewing), 2016-01-07 23:31:52]

Description was changed from

==========
Update tools/perf to use cloud_storage from catapult.

This is part of the migration work needed before we can remove the version
in telemetry.

BUG=565604
==========

to

==========
Update tools/perf to use cloud_storage from catapult.

This is part of the migration work needed before we can remove the version
in telemetry.

BUG=565604
==========

[aiolos (Not reviewing), 2016-01-07 23:31:52]

aiolos@chromium.org changed reviewers:
+ eakuefner@chromium.org, erikchen@chromium.org

[erikchen, 2016-01-08 00:33:29]

https://codereview.chromium.org/1568103002/diff/1/tools/perf/profile_creators...
File tools/perf/profile_creators/__init__.py (right):

https://codereview.chromium.org/1568103002/diff/1/tools/perf/profile_creators...
tools/perf/profile_creators/__init__.py:8: chromium_src_path =
os.path.realpath(os.path.join(
This looks like duplicated code. Is there a reason this code shouldn't be
shared?

[aiolos (Not reviewing), 2016-01-08 19:01:16]

https://codereview.chromium.org/1568103002/diff/1/tools/perf/profile_creators...
File tools/perf/profile_creators/__init__.py (right):

https://codereview.chromium.org/1568103002/diff/1/tools/perf/profile_creators...
tools/perf/profile_creators/__init__.py:8: chromium_src_path =
os.path.realpath(os.path.join(
On 2016/01/08 00:33:29, erikchen wrote:
> This looks like duplicated code. Is there a reason this code shouldn't be
> shared? 

Nope, good call.

[erikchen, 2016-01-08 19:03:03]

lgtm

[eakuefner, 2016-01-08 19:54:54]

lgtm

https://codereview.chromium.org/1568103002/diff/20001/tools/perf/core/path_ut...
File tools/perf/core/path_util.py (right):

https://codereview.chromium.org/1568103002/diff/20001/tools/perf/core/path_ut...
tools/perf/core/path_util.py:44: sys.path.insert(1, catapult_base_path)
If you do client_config in this CL, you can add here:

def GetPerfClientConfigPath():
  return os.path.join(GetPerfDir(), 'core', 'binary_dependencies.json')

https://codereview.chromium.org/1568103002/diff/20001/tools/perf/fetch_benchm...
File tools/perf/fetch_benchmark_deps.py (right):

https://codereview.chromium.org/1568103002/diff/20001/tools/perf/fetch_benchm...
tools/perf/fetch_benchmark_deps.py:66:
benchmark_dirs=[path_util.GetPerfDir('benchmarks')])
While you're at it, maybe you can consider adding client_config in this patch?
If you do it I'll close my https://codereview.chromium.org/1383773002 which has
not landed yet.

[aiolos (Not reviewing), 2016-01-08 20:25:27]

https://codereview.chromium.org/1568103002/diff/20001/tools/perf/core/path_ut...
File tools/perf/core/path_util.py (right):

https://codereview.chromium.org/1568103002/diff/20001/tools/perf/core/path_ut...
tools/perf/core/path_util.py:44: sys.path.insert(1, catapult_base_path)
On 2016/01/08 19:54:54, eakuefner wrote:
> If you do client_config in this CL, you can add here:
> 
> def GetPerfClientConfigPath():
>   return os.path.join(GetPerfDir(), 'core', 'binary_dependencies.json')

Do we actually need that? That path gets passed in by default to ClientConfig. I
think we prefer people using that class instead of them manually setting the
config file.

https://codereview.chromium.org/1568103002/diff/20001/tools/perf/fetch_benchm...
File tools/perf/fetch_benchmark_deps.py (right):

https://codereview.chromium.org/1568103002/diff/20001/tools/perf/fetch_benchm...
tools/perf/fetch_benchmark_deps.py:66:
benchmark_dirs=[path_util.GetPerfDir('benchmarks')])
On 2016/01/08 19:54:54, eakuefner wrote:
> While you're at it, maybe you can consider adding client_config in this patch?
> If you do it I'll close my https://codereview.chromium.org/1383773002 which
has
> not landed yet.

Done.

[eakuefner, 2016-01-08 20:31:22]

https://codereview.chromium.org/1568103002/diff/20001/tools/perf/core/path_ut...
File tools/perf/core/path_util.py (right):

https://codereview.chromium.org/1568103002/diff/20001/tools/perf/core/path_ut...
tools/perf/core/path_util.py:44: sys.path.insert(1, catapult_base_path)
On 2016/01/08 at 20:25:27, aiolos wrote:
> On 2016/01/08 19:54:54, eakuefner wrote:
> > If you do client_config in this CL, you can add here:
> > 
> > def GetPerfClientConfigPath():
> >   return os.path.join(GetPerfDir(), 'core', 'binary_dependencies.json')
> 
> Do we actually need that? That path gets passed in by default to ClientConfig.
I think we prefer people using that class instead of them manually setting the
config file.

Oh, I see. I didn't realize that ChromiumConfig works the way it does. I think
it's fine as you have it now.

[aiolos (Not reviewing), 2016-01-08 20:34:00]

The CQ bit was checked by aiolos@chromium.org

[aiolos (Not reviewing), 2016-01-08 20:34:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1568103002/#ps40001
(title: "Update fetch_benchmark_deps to use ChromiumConfig")

[commit-bot: I haz the power, 2016-01-08 20:34:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568103002/40001

[commit-bot: I haz the power, 2016-01-08 21:29:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 21:29:08]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aiolos (Not reviewing), 2016-01-20 01:15:43]

The CQ bit was checked by aiolos@chromium.org

[commit-bot: I haz the power, 2016-01-20 01:16:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568103002/40001

[commit-bot: I haz the power, 2016-01-20 01:23:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 01:23:12]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aiolos (Not reviewing), 2016-01-20 01:35:54]

The CQ bit was checked by aiolos@chromium.org

[aiolos (Not reviewing), 2016-01-20 01:35:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1568103002/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-01-20 01:38:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568103002/60001

[commit-bot: I haz the power, 2016-01-20 02:48:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 02:48:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aiolos (Not reviewing), 2016-01-20 16:07:43]

Patchset #5 (id:80001) has been deleted

[aiolos (Not reviewing), 2016-01-20 17:44:32]

The CQ bit was checked by aiolos@chromium.org

[aiolos (Not reviewing), 2016-01-20 17:44:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1568103002/#ps100001
(title: "Fix failing fetch_benchmark_deps unittest + rebase.")

[commit-bot: I haz the power, 2016-01-20 17:45:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568103002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568103002/100001

[commit-bot: I haz the power, 2016-01-20 18:17:55]

Description was changed from

==========
Update tools/perf to use cloud_storage from catapult.

This is part of the migration work needed before we can remove the version
in telemetry.

BUG=565604
==========

to

==========
Update tools/perf to use cloud_storage from catapult.

This is part of the migration work needed before we can remove the version
in telemetry.

BUG=565604
==========

[commit-bot: I haz the power, 2016-01-20 18:17:56]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-01-20 18:18:47]

Description was changed from

==========
Update tools/perf to use cloud_storage from catapult.

This is part of the migration work needed before we can remove the version
in telemetry.

BUG=565604
==========

to

==========
Update tools/perf to use cloud_storage from catapult.

This is part of the migration work needed before we can remove the version
in telemetry.

BUG=565604

Committed: https://crrev.com/052022a2e262ed58a4cabd4b1f01aa22e4b09245
Cr-Commit-Position: refs/heads/master@{#370427}
==========

[commit-bot: I haz the power, 2016-01-20 18:18:48]

Patchset 5 (id:??) landed as
https://crrev.com/052022a2e262ed58a4cabd4b1f01aa22e4b09245
Cr-Commit-Position: refs/heads/master@{#370427}