tools/perf/profile_creators/__init__.py - Issue 1568103002: Update tools/perf to use cloud_storage from catapult.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/profile_creators/init.py

Issue 1568103002: Update tools/perf to use cloud_storage from catapult. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 """Generators for Chrome profiles for testing purposes."""	4 """Generators for Chrome profiles for testing purposes."""

	5 import os

	6 import sys

	7

	8 chromium_src_path = os.path.realpath(os.path.join(
	erikchen 2016/01/08 00:33:29 This looks like duplicated code. Is there a reason This looks like duplicated code. Is there a reason this code shouldn't be shared? aiolos (Not reviewing) 2016/01/08 19:01:16 Nope, good call. Show quoted text On 2016/01/08 00:33:29, erikchen wrote: > This looks like duplicated code. Is there a reason this code shouldn't be > shared? Nope, good call.
	9 os.path.abspath(__file__), '..', '..', '..', '..'))

	10

	11 telemetry_path = os.path.join(chromium_src_path, 'tools', 'telemetry')

	12 if telemetry_path not in sys.path:

	13 sys.path.insert(1, telemetry_path)

	14

	15 catapult_base_path = os.path.join(

	16 chromium_src_path, 'third_party', 'catapult', 'catapult_base')

	17 if catapult_base_path not in sys.path:

	18 sys.path.insert(1, catapult_base_path)

OLD	NEW

« no previous file with comments | « tools/perf/fetch_benchmark_deps.py ('k') | tools/perf/profile_creators/update_remote_extensions.py » ('j') | no next file with comments »

Side by Side Diff: tools/perf/profile_creators/__init__.py

Side by Side Diff: tools/perf/profile_creators/init.py