Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/perf/fetch_benchmark_deps_unittest.py

Issue 1568103002: Update tools/perf to use cloud_storage from catapult. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failing fetch_benchmark_deps unittest + rebase. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/fetch_benchmark_deps.py ('k') | tools/perf/profile_creators/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/fetch_benchmark_deps_unittest.py
diff --git a/tools/perf/fetch_benchmark_deps_unittest.py b/tools/perf/fetch_benchmark_deps_unittest.py
index 52baf66c8d495fa1f7ea90e389a3bddc2ff5f81a..2b07d9994adcb7dc78fa9662b924446b4c1d5110 100644
--- a/tools/perf/fetch_benchmark_deps_unittest.py
+++ b/tools/perf/fetch_benchmark_deps_unittest.py
@@ -9,6 +9,7 @@ import StringIO
import mock # pylint: disable=import-error
+from core import path_util
import fetch_benchmark_deps
@@ -51,7 +52,7 @@ class FetchBenchmarkDepsUnittest(unittest.TestCase):
mock_get.GetFilesInDirectoryIfChanged.return_value = True
fetch_benchmark_deps.main(output)
for f in output.getvalue().splitlines():
- fullpath = os.path.join(fetch_benchmark_deps.GetChromiumDir(), f)
+ fullpath = os.path.join(path_util.GetChromiumSrcDir(), f)
sha1path = fullpath + '.sha1'
self.assertTrue(os.path.isfile(sha1path))
if expected_fetched_file_paths:
@@ -68,5 +69,5 @@ class FetchBenchmarkDepsUnittest(unittest.TestCase):
octane_wpr_path = os.path.join(
os.path.dirname(__file__), 'page_sets', 'data', 'octane_001.wpr')
expected = os.path.relpath(octane_wpr_path,
- fetch_benchmark_deps.GetChromiumDir())
+ path_util.GetChromiumSrcDir())
self._RunFetchBenchmarkDepsTest('octane', NormPaths(expected))
« no previous file with comments | « tools/perf/fetch_benchmark_deps.py ('k') | tools/perf/profile_creators/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698