Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1383773002: [Telemetry] Update tools/perf/fetch_benchmark_deps.py to use client_config (Closed)

Created:
5 years, 2 months ago by eakuefner
Modified:
4 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Update tools/perf/fetch_benchmark_deps.py to use client_config BUG=538192 R=aiolos TEST=tools/perf/fetch_benchmark_deps.py smoothness.top_25_smooth

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Kari's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M tools/perf/core/path_util.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tools/perf/fetch_benchmark_deps.py View 1 3 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
eakuefner
5 years, 2 months ago (2015-10-01 16:22:57 UTC) #1
aiolos (Not reviewing)
lgtm https://codereview.chromium.org/1383773002/diff/1/tools/perf/fetch_benchmark_deps.py File tools/perf/fetch_benchmark_deps.py (right): https://codereview.chromium.org/1383773002/diff/1/tools/perf/fetch_benchmark_deps.py#newcode17 tools/perf/fetch_benchmark_deps.py:17: def _GetPerfDir(*subdirs): These functions are in path_util now. ...
5 years, 2 months ago (2015-10-13 13:40:15 UTC) #2
eakuefner
https://codereview.chromium.org/1383773002/diff/1/tools/perf/fetch_benchmark_deps.py File tools/perf/fetch_benchmark_deps.py (right): https://codereview.chromium.org/1383773002/diff/1/tools/perf/fetch_benchmark_deps.py#newcode17 tools/perf/fetch_benchmark_deps.py:17: def _GetPerfDir(*subdirs): On 2015/10/13 at 13:40:15, aiolos wrote: > ...
4 years, 11 months ago (2016-01-06 23:15:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383773002/20001
4 years, 11 months ago (2016-01-06 23:16:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/161503)
4 years, 11 months ago (2016-01-06 23:54:31 UTC) #8
aiolos (Not reviewing)
4 years, 11 months ago (2016-01-20 23:00:09 UTC) #9 
I think this cl is obsolete at this point.

Powered by Google App Engine
This is Rietveld 408576698