media/mojo/services/mojo_cdm.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/mojo_cdm.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mojo/services/mojo_cdm.cc

diff --git a/media/mojo/services/mojo_cdm.cc b/media/mojo/services/mojo_cdm.cc

index 31dd4a7a0434f0c8a2bc43b0207839e09e8c8c5b..aa65086afd4cca47581954a38176125e4bc31817 100644

--- a/media/mojo/services/mojo_cdm.cc

+++ b/media/mojo/services/mojo_cdm.cc

@@ -184,7 +184,7 @@ void MojoCdm::OnSessionMessage(const mojo::String& session_id,

mojo::Array<uint8_t> message,

const mojo::String& legacy_destination_url) {

DVLOG(2) << __FUNCTION__;

- GURL verified_gurl = GURL(legacy_destination_url);

+ GURL verified_gurl = GURL(legacy_destination_url.get());

if (!verified_gurl.is_valid() && !verified_gurl.is_empty()) {

DLOG(WARNING) << "SessionMessage destination_url is invalid : "

<< verified_gurl.possibly_invalid_spec();