media/blink/webmediaplayer_impl.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/webmediaplayer_impl.cc

diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc

index 03818aff63b1b120fcb62dfd521a45cd693a4c68..c4fbb5fdae86202ca8ee668a549c3e87e51ecd67 100644

--- a/media/blink/webmediaplayer_impl.cc

+++ b/media/blink/webmediaplayer_impl.cc

@@ -261,8 +261,9 @@ void WebMediaPlayerImpl::DoLoad(LoadType load_type,

DCHECK(main_task_runner_->BelongsToCurrentThread());

GURL gurl(url);

- ReportMetrics(load_type, gurl,

- GURL(frame_->document().securityOrigin().toString()));

+ ReportMetrics(

+ load_type, gurl,

+ GURL(base::string16(frame_->document().securityOrigin().toString())));

// Set subresource URL for crash reporting.

base::debug::SetCrashKeyValue("subresource_url", gurl.spec());