media/mojo/services/mojo_cdm_service.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/mojo_cdm_service.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mojo/services/mojo_cdm_service.cc

diff --git a/media/mojo/services/mojo_cdm_service.cc b/media/mojo/services/mojo_cdm_service.cc

index 31781b11e5fc5ec183dcd62c50f86ee04c0d3d5f..74c6a147c3585948ba2ab91777a410560ac415a8 100644

--- a/media/mojo/services/mojo_cdm_service.cc

+++ b/media/mojo/services/mojo_cdm_service.cc

@@ -113,7 +113,7 @@ void MojoCdmService::Initialize(const mojo::String& key_system,

auto weak_this = weak_factory_.GetWeakPtr();

cdm_factory_->Create(

- key_system, GURL(security_origin), cdm_config.To<CdmConfig>(),

+ key_system, GURL(security_origin.get()), cdm_config.To<CdmConfig>(),

base::Bind(&MojoCdmService::OnSessionMessage, weak_this),

base::Bind(&MojoCdmService::OnSessionClosed, weak_this),

base::Bind(&MojoCdmService::OnLegacySessionError, weak_this),