Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1567623008: Add vcvt<c>.f32.f64 and vcvt<c>.f64.32 to ARM. (Closed)

Created:
4 years, 11 months ago by Karl
Modified:
4 years, 11 months ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit and merge conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -5 lines) Patch
M src/DartARM32/assembler_arm.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 1 chunk +47 lines, -0 lines 0 comments Download
M src/IceInstARM32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 1 chunk +18 lines, -0 lines 0 comments Download
A tests_lit/assembler/arm32/vcvt_f32_f64.ll View 1 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
4 years, 11 months ago (2016-01-07 21:34:03 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1567623008/diff/1/tests_lit/assembler/arm32/vcvt_f32_f64.ll File tests_lit/assembler/arm32/vcvt_f32_f64.ll (right): https://codereview.chromium.org/1567623008/diff/1/tests_lit/assembler/arm32/vcvt_f32_f64.ll#newcode64 tests_lit/assembler/arm32/vcvt_f32_f64.ll:64: Trailing whitespace makes git sad.
4 years, 11 months ago (2016-01-07 23:33:18 UTC) #4
Karl
Committed patchset #2 (id:2) manually as 6c7181c5d3f082cbc04b58dd4745253139ad51e0 (presubmit successful).
4 years, 11 months ago (2016-01-08 15:31:13 UTC) #6
Karl
4 years, 11 months ago (2016-01-08 15:31:28 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1567623008/diff/1/tests_lit/assembler/arm32/v...
File tests_lit/assembler/arm32/vcvt_f32_f64.ll (right):

https://codereview.chromium.org/1567623008/diff/1/tests_lit/assembler/arm32/v...
tests_lit/assembler/arm32/vcvt_f32_f64.ll:64: 
On 2016/01/07 23:33:17, stichnot wrote:
> Trailing whitespace makes git sad.

Removed.

Powered by Google App Engine
This is Rietveld 408576698