Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1566713002: Use base/macros.h instead of base/basictypes.h (Closed)

Created:
4 years, 11 months ago by Mark Mentovai
Modified:
4 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Use base/macros.h instead of base/basictypes.h This was done in Chromium’s local copy of Crashpad in 562827afb599. This change is similar to that one, except more care was taken to avoid including headers from a .cc or _test.cc when already included by the associated .h. Rather than using <stddef.h> for size_t, Crashpad has always used <sys/types.h>, so that’s used here as well. This updates mini_chromium to 8a2363f486e3a0dc562a68884832d06d28d38dcc, which removes base/basictypes.h. e128dcf10122 Remove base/move.h; use std::move() instead of Pass() 8a2363f486e3 Move basictypes.h to macros.h R=avi@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/6d2d31d2d137ecad64b412dcf1342076a5144661

Patch Set 1 #

Patch Set 2 : Windows #incldue → #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -236 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M client/crash_report_database.h View 1 chunk +1 line, -1 line 0 comments Download
M client/crash_report_database_win.cc View 1 chunk +4 lines, -1 line 0 comments Download
M client/crashpad_client.h View 1 chunk +1 line, -1 line 0 comments Download
M client/crashpad_client_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M client/crashpad_client_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M client/crashpad_info.h View 1 chunk +1 line, -2 lines 0 comments Download
M client/prune_crash_reports.h View 1 chunk +2 lines, -1 line 0 comments Download
M client/prune_crash_reports.cc View 1 chunk +1 line, -0 lines 0 comments Download
M client/settings.h View 1 chunk +1 line, -1 line 0 comments Download
M client/settings.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M client/settings_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M client/simple_string_dictionary.h View 1 chunk +2 lines, -1 line 0 comments Download
M client/simulate_crash_mac.cc View 1 chunk +2 lines, -1 line 0 comments Download
M client/simulate_crash_mac_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M compat/non_win/winnt.h View 1 chunk +2 lines, -0 lines 0 comments Download
M handler/crash_report_upload_thread.h View 2 chunks +3 lines, -2 lines 0 comments Download
M handler/handler_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M handler/mac/crash_report_exception_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M handler/mac/exception_handler_server.h View 1 chunk +1 line, -2 lines 0 comments Download
M handler/prune_crash_reports_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M handler/win/crash_report_exception_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M handler/win/crashy_test_program.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M minidump/minidump_context_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_context_writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_crashpad_info_writer.h View 1 chunk +3 lines, -1 line 0 comments Download
M minidump/minidump_exception_writer.h View 1 chunk +2 lines, -1 line 0 comments Download
M minidump/minidump_exception_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M minidump/minidump_exception_writer_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M minidump/minidump_file_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_file_writer_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M minidump/minidump_handle_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_memory_info_writer.h View 1 chunk +2 lines, -1 line 0 comments Download
M minidump/minidump_memory_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_memory_writer_test.cc View 1 chunk +1 line, -5 lines 0 comments Download
M minidump/minidump_misc_info_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_misc_info_writer_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M minidump/minidump_module_crashpad_info_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_module_crashpad_info_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M minidump/minidump_module_writer.h View 1 chunk +2 lines, -1 line 0 comments Download
M minidump/minidump_module_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M minidump/minidump_module_writer_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M minidump/minidump_rva_list_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_simple_string_dictionary_writer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M minidump/minidump_simple_string_dictionary_writer_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M minidump/minidump_stream_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_string_writer.h View 1 chunk +2 lines, -1 line 0 comments Download
M minidump/minidump_string_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M minidump/minidump_string_writer_test.cc View 1 chunk +1 line, -5 lines 0 comments Download
M minidump/minidump_system_info_writer.h View 1 chunk +2 lines, -1 line 0 comments Download
M minidump/minidump_system_info_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M minidump/minidump_system_info_writer_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M minidump/minidump_thread_id_map_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M minidump/minidump_thread_writer.h View 1 chunk +2 lines, -1 line 0 comments Download
M minidump/minidump_thread_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M minidump/minidump_thread_writer_test.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M minidump/minidump_writable.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_writable_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_writer_util.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/test/minidump_context_test_util.cc View 1 chunk +4 lines, -1 line 0 comments Download
M minidump/test/minidump_memory_writer_test_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M minidump/test/minidump_rva_list_test_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M minidump/test/minidump_string_writer_test_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M minidump/test/minidump_writable_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/cpu_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M snapshot/cpu_context_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M snapshot/crashpad_info_client_options.h View 1 chunk +2 lines, -0 lines 0 comments Download
M snapshot/crashpad_info_client_options_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M snapshot/mac/exception_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/mach_o_image_annotations_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/mach_o_image_annotations_reader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M snapshot/mac/mach_o_image_annotations_reader_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M snapshot/mac/mach_o_image_reader.h View 1 chunk +2 lines, -1 line 0 comments Download
M snapshot/mac/mach_o_image_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/mach_o_image_segment_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/mach_o_image_segment_reader_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/mach_o_image_symbol_table_reader.h View 1 chunk +1 line, -2 lines 0 comments Download
M snapshot/mac/mach_o_image_symbol_table_reader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M snapshot/mac/memory_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/module_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/process_reader.h View 2 chunks +2 lines, -1 line 0 comments Download
M snapshot/mac/process_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/process_types.cc View 1 chunk +1 line, -0 lines 0 comments Download
M snapshot/mac/process_types/custom.cc View 1 chunk +1 line, -0 lines 0 comments Download
M snapshot/mac/process_types_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M snapshot/mac/system_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/thread_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/minidump/minidump_simple_string_dictionary_reader.cc View 1 chunk +3 lines, -1 line 0 comments Download
M snapshot/minidump/minidump_string_list_reader.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M snapshot/minidump/minidump_string_reader.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M snapshot/minidump/module_snapshot_minidump.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/minidump/process_snapshot_minidump.h View 1 chunk +4 lines, -3 lines 0 comments Download
M snapshot/minidump/process_snapshot_minidump_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/test/test_cpu_context.cc View 1 chunk +4 lines, -1 line 0 comments Download
M snapshot/test/test_exception_snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/test/test_memory_map_region_snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/test/test_memory_snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/test/test_module_snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/test/test_process_snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/test/test_system_snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/test/test_thread_snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/win/cpu_context_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M snapshot/win/exception_snapshot_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M snapshot/win/memory_snapshot_win.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/win/module_snapshot_win.h View 1 chunk +2 lines, -3 lines 0 comments Download
M snapshot/win/pe_image_annotations_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/win/pe_image_annotations_reader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M snapshot/win/pe_image_annotations_reader_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/win/pe_image_reader.h View 1 chunk +3 lines, -1 line 0 comments Download
M snapshot/win/pe_image_resource_reader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M snapshot/win/process_reader_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M snapshot/win/process_reader_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M snapshot/win/process_reader_win_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/win/process_snapshot_win.h View 2 chunks +3 lines, -2 lines 0 comments Download
M snapshot/win/process_snapshot_win_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M snapshot/win/process_subrange_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/win/system_snapshot_win.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/win/system_snapshot_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/win/thread_snapshot_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/file.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mac/mach_multiprocess.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mac/mach_multiprocess_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/multiprocess.h View 1 chunk +1 line, -1 line 0 comments Download
M test/multiprocess_exec.h View 1 chunk +1 line, -1 line 0 comments Download
M test/multiprocess_exec_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/multiprocess_exec_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/multiprocess_posix_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/paths.h View 1 chunk +1 line, -1 line 0 comments Download
M test/scoped_temp_dir.h View 1 chunk +1 line, -1 line 0 comments Download
M test/win/win_child_process.h View 1 chunk +1 line, -1 line 0 comments Download
M test/win/win_child_process_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/win/win_multiprocess.h View 1 chunk +1 line, -1 line 0 comments Download
M test/win/win_multiprocess_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/crashpad_database_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/mac/catch_exception_tool.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/mac/exception_port_tool.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/tool_support.h View 1 chunk +1 line, -1 line 0 comments Download
M util/file/file_io_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/file/file_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M util/file/file_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M util/file/file_writer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M util/file/string_file.h View 1 chunk +1 line, -1 line 0 comments Download
M util/file/string_file_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M util/mac/checked_mach_address_range_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M util/mac/launchd.h View 1 chunk +1 line, -0 lines 0 comments Download
M util/mac/launchd_test.mm View 1 chunk +2 lines, -1 line 0 comments Download
M util/mac/xattr.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M util/mach/child_port_handshake.h View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/child_port_handshake.cc View 1 chunk +1 line, -0 lines 0 comments Download
M util/mach/child_port_server.h View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/composite_mach_message_server.h View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/composite_mach_message_server_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M util/mach/exc_client_variants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M util/mach/exc_client_variants_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M util/mach/exc_server_variants.h View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/exc_server_variants.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/exc_server_variants_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M util/mach/exception_behaviors_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M util/mach/exception_ports.h View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/exception_ports_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/exception_types_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M util/mach/mach_message_server.h View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/mach_message_server_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M util/mach/mach_message_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M util/mach/notify_server.h View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/notify_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/scoped_task_suspend.h View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/symbolic_constants_mach.cc View 1 chunk +2 lines, -1 line 0 comments Download
M util/mach/symbolic_constants_mach_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M util/mach/task_for_pid.cc View 1 chunk +0 lines, -1 line 0 comments Download
M util/mach/task_memory.h View 1 chunk +2 lines, -1 line 0 comments Download
M util/misc/clock_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M util/misc/clock_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/misc/initialization_state.h View 1 chunk +1 line, -1 line 0 comments Download
M util/misc/initialization_state_dcheck.h View 1 chunk +1 line, -1 line 0 comments Download
M util/misc/pdb_structures.h View 1 chunk +2 lines, -0 lines 0 comments Download
M util/misc/random_string_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M util/misc/scoped_forbid_return.h View 1 chunk +1 line, -1 line 0 comments Download
M util/misc/uuid.cc View 1 chunk +0 lines, -1 line 0 comments Download
M util/misc/uuid_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M util/net/http_body.h View 1 chunk +1 line, -1 line 0 comments Download
M util/net/http_body_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M util/net/http_multipart_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M util/net/http_multipart_builder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M util/net/http_multipart_builder_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M util/net/http_transport.h View 1 chunk +1 line, -1 line 0 comments Download
M util/net/http_transport_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M util/net/http_transport_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M util/numeric/checked_address_range.h View 1 chunk +1 line, -0 lines 0 comments Download
M util/numeric/checked_address_range_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M util/numeric/checked_range.h View 1 chunk +0 lines, -1 line 0 comments Download
M util/numeric/checked_range_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M util/numeric/int128_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/posix/close_stdio.cc View 1 chunk +0 lines, -1 line 0 comments Download
M util/posix/process_info.h View 1 chunk +1 line, -1 line 0 comments Download
M util/posix/symbolic_constants_posix.cc View 1 chunk +4 lines, -1 line 0 comments Download
M util/posix/symbolic_constants_posix_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M util/stdlib/pointer_container.h View 1 chunk +1 line, -1 line 0 comments Download
M util/stdlib/string_number_conversion_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M util/stdlib/strlcpy.h View 1 chunk +1 line, -1 line 0 comments Download
M util/stdlib/strlcpy_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/stdlib/strnlen.h View 1 chunk +1 line, -0 lines 0 comments Download
M util/string/split_string.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M util/synchronization/semaphore_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M util/thread/thread.h View 1 chunk +1 line, -1 line 0 comments Download
M util/thread/thread_log_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M util/thread/thread_log_messages.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M util/thread/thread_log_messages_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M util/thread/thread_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/thread/worker_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M util/win/capture_context_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M util/win/command_line.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M util/win/command_line_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M util/win/exception_handler_server.h View 1 chunk +1 line, -1 line 0 comments Download
M util/win/exception_handler_server.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M util/win/exception_handler_server_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M util/win/module_version.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M util/win/ntstatus_logging.h View 1 chunk +1 line, -1 line 0 comments Download
M util/win/process_info.h View 1 chunk +2 lines, -2 lines 0 comments Download
M util/win/process_info_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/win/scoped_process_suspend.h View 1 chunk +1 line, -1 line 0 comments Download
M util/win/time.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Mark Mentovai
4 years, 11 months ago (2016-01-06 15:42:00 UTC) #2
Avi (use Gerrit)
lgtm A nice and carefully crafted update.
4 years, 11 months ago (2016-01-06 16:44:36 UTC) #3
Mark Mentovai
4 years, 11 months ago (2016-01-06 17:22:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6d2d31d2d137ecad64b412dcf1342076a5144661 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698