util/stdlib/string_number_conversion_test.cc - Issue 1566713002: Use base/macros.h instead of base/basictypes.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/stdlib/string_number_conversion_test.cc

Issue 1566713002: Use base/macros.h instead of base/basictypes.h (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Windows #incldue → #include Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/stdlib/string_number_conversion_test.cc

diff --git a/util/stdlib/string_number_conversion_test.cc b/util/stdlib/string_number_conversion_test.cc

index 97d3152bbae4d9d7efc35b12234a06299c846a02..6fe6f8133e15533b7704c442ec8803cd0ad5a5f6 100644

--- a/util/stdlib/string_number_conversion_test.cc

+++ b/util/stdlib/string_number_conversion_test.cc

@@ -14,11 +14,13 @@

#include "util/stdlib/string_number_conversion.h"

-#include "base/basictypes.h"

-#include "gtest/gtest.h"

+#include <sys/types.h>

#include <limits>

+#include "base/macros.h"

+#include "gtest/gtest.h"

namespace crashpad {

namespace test {

namespace {

« no previous file with comments | « util/stdlib/pointer_container.h ('k') | util/stdlib/strlcpy.h » ('j') | no next file with comments »