snapshot/win/process_snapshot_win.h - Issue 1566713002: Use base/macros.h instead of base/basictypes.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/process_snapshot_win.h

Issue 1566713002: Use base/macros.h instead of base/basictypes.h (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Windows #incldue → #include Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: snapshot/win/process_snapshot_win.h

diff --git a/snapshot/win/process_snapshot_win.h b/snapshot/win/process_snapshot_win.h

index a1dd72334d6e28e3e00d5898d6084009ca7cd3a1..64e73da167bedb7c5a7c2ca273d897b1ca5e1e7d 100644

--- a/snapshot/win/process_snapshot_win.h

+++ b/snapshot/win/process_snapshot_win.h

@@ -17,12 +17,13 @@

#include <windows.h>

#include <sys/time.h>

+#include <sys/types.h>

#include <map>

#include <string>

#include <vector>

-#include "base/basictypes.h"

+#include "base/macros.h"

#include "base/memory/scoped_ptr.h"

#include "client/crashpad_info.h"

#include "snapshot/crashpad_info_client_options.h"

@@ -41,9 +42,9 @@

#include "snapshot/win/thread_snapshot_win.h"

#include "util/misc/initialization_state_dcheck.h"

#include "util/misc/uuid.h"

+#include "util/stdlib/pointer_container.h"

#include "util/win/address_types.h"

#include "util/win/process_structs.h"

-#include "util/stdlib/pointer_container.h"

namespace crashpad {

« no previous file with comments | « snapshot/win/process_reader_win_test.cc ('k') | snapshot/win/process_snapshot_win_test.cc » ('j') | no next file with comments »