minidump/minidump_thread_writer_test.cc - Issue 1566713002: Use base/macros.h instead of base/basictypes.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_thread_writer_test.cc

Issue 1566713002: Use base/macros.h instead of base/basictypes.h (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Windows #incldue → #include Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_thread_writer_test.cc

diff --git a/minidump/minidump_thread_writer_test.cc b/minidump/minidump_thread_writer_test.cc

index ab0561a92270d841d878777bfc468c7f2c318895..86a5d936f21adbd4c408e617db1bf011ffe57fa0 100644

--- a/minidump/minidump_thread_writer_test.cc

+++ b/minidump/minidump_thread_writer_test.cc

@@ -14,10 +14,6 @@

#include "minidump/minidump_thread_writer.h"

-#include <windows.h>

-#include <dbghelp.h>

-#include <sys/types.h>

#include <string>

#include <utility>

@@ -26,12 +22,12 @@

#include "base/strings/stringprintf.h"

#include "gtest/gtest.h"

#include "minidump/minidump_context_writer.h"

-#include "minidump/minidump_memory_writer.h"

#include "minidump/minidump_file_writer.h"

+#include "minidump/minidump_memory_writer.h"

#include "minidump/minidump_thread_id_map.h"

#include "minidump/test/minidump_context_test_util.h"

-#include "minidump/test/minidump_memory_writer_test_util.h"

#include "minidump/test/minidump_file_writer_test_util.h"

+#include "minidump/test/minidump_memory_writer_test_util.h"

#include "minidump/test/minidump_writable_test_util.h"

#include "snapshot/test/test_cpu_context.h"

#include "snapshot/test/test_memory_snapshot.h"

« no previous file with comments | « minidump/minidump_thread_writer.cc ('k') | minidump/minidump_writable.h » ('j') | no next file with comments »