Issue 155983003: GN iOS build fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155983003: GN iOS build fixes. (Closed)

Created:
6 years, 10 months ago by brettw

Modified:
6 years, 10 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GN iOS build fixes. This properly sets the DEPLOYMENT_TARGET in the generated GYP file (previously this value wa salways hardcoded to empty -- whoops!). Sets the simulator properly. Previously when not using an explicit SDK the Xcode generator would still end up with a simulator build. This turns the flag into a tri-state so gyp_chromium can set it explicitly when an SDK is specified, but otherwise we can trigger default behavior based on Xcode/Ninja. TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249643

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -11 lines)			Patch
M	build/config/ios/ios_sdk.gni	View	1	1 chunk	+15 lines, -5 lines	0 comments	Download
M	build/gyp_chromium	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	tools/gn/gyp_binary_target_writer.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/155983003/30001

6 years, 10 months ago (2014-02-07 03:59:22 UTC) #2

Message was sent while issue was closed.

Change committed as 249643

Expand Messages | Collapse Messages