Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5201)

Unified Diff: build/config/ios/ios_sdk.gni

Issue 155983003: GN iOS build fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/gyp_chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/ios_sdk.gni
diff --git a/build/config/ios/ios_sdk.gni b/build/config/ios/ios_sdk.gni
index 7acbaaa17d78c5e5a31372172261707e53fcb422..dce993d5cf42fb1888ddb787f6165a5340c4d990 100644
--- a/build/config/ios/ios_sdk.gni
+++ b/build/config/ios/ios_sdk.gni
@@ -8,15 +8,25 @@ declare_args() {
ios_sdk_path = ""
# Set to true when targeting a simulator build on iOS. False means that the
- # target is for running on the device.
- use_ios_simulator = true
+ # target is for running on the device. The default value (the empty string)
+ # means to pick the default based on the generator.
+ use_ios_simulator = ""
+ # Version of iOS that we're targeting.
ios_deployment_target = "6.0"
}
-if (!is_gyp_xcode_generator) {
- # The Ninja build currently only targets the simulator.
- assert(use_ios_simulator, "You can't do an iOS device build using Ninja yet.")
+if (use_ios_simulator == "") {
+ # Pick the default based on the generator. Currently, the Ninja build only
+ # supports the simulator, while we default to device builds on Xcode.
+ use_ios_simulator = !is_gyp_xcode_generator
+} else {
+ # Simulator flag explicitly passed in.
+ if (!is_gyp_xcode_generator) {
+ # The Ninja build currently only targets the simulator.
+ assert(use_ios_simulator,
+ "You can't do an iOS device build using Ninja yet.")
+ }
}
if (ios_sdk_path == "") {
« no previous file with comments | « no previous file | build/gyp_chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698