Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Side by Side Diff: build/gyp_chromium

Issue 155983003: GN iOS build fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « build/config/ios/ios_sdk.gni ('k') | tools/gn/gyp_binary_target_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 # This script is wrapper for Chromium that adds some support for how GYP 7 # This script is wrapper for Chromium that adds some support for how GYP
8 # is invoked by Chromium beyond what can be done in the gclient hooks. 8 # is invoked by Chromium beyond what can be done in the gclient hooks.
9 9
10 import glob 10 import glob
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 # These string arguments get passed directly as GN strings. 226 # These string arguments get passed directly as GN strings.
227 for v in ['android_src', 'arm_float_abi', 'ios_deployment_target', 227 for v in ['android_src', 'arm_float_abi', 'ios_deployment_target',
228 'ios_sdk_path', 'windows_sdk_path']: 228 'ios_sdk_path', 'windows_sdk_path']:
229 if v in vars_dict: 229 if v in vars_dict:
230 gn_args += ' ' + v + '=' + EscapeStringForGN(vars_dict[v]) 230 gn_args += ' ' + v + '=' + EscapeStringForGN(vars_dict[v])
231 231
232 # gomadir is renamed goma_dir in the GN build. 232 # gomadir is renamed goma_dir in the GN build.
233 if 'gomadir' in vars_dict: 233 if 'gomadir' in vars_dict:
234 gn_args += ' goma_dir=%s' % EscapeStringForGN(vars_dict['gomadir']) 234 gn_args += ' goma_dir=%s' % EscapeStringForGN(vars_dict['gomadir'])
235 235
236 # Clear the "use_ios_simulator" flag if the ios_sdk_path is set and is 236 # Set the "use_ios_simulator" flag if the ios_sdk_path is set.
237 # not a simulator SDK. This duplicates code done in GYP's xcode emulation.
238 if 'ios_sdk_path' in vars_dict: 237 if 'ios_sdk_path' in vars_dict:
239 if not os.path.basename(vars_dict['ios_sdk_path']).lower().startswith( 238 if os.path.basename(vars_dict['ios_sdk_path']).lower().startswith(
240 'iphonesimulator'): 239 'iphonesimulator'):
240 gn_args += ' use_ios_simulator=true'
241 else:
241 gn_args += ' use_ios_simulator=false' 242 gn_args += ' use_ios_simulator=false'
242 243
243
244 # These arguments get passed directly as integers (avoiding the quoting and 244 # These arguments get passed directly as integers (avoiding the quoting and
245 # escaping of the string ones above). 245 # escaping of the string ones above).
246 for v in ['arm_version']: 246 for v in ['arm_version']:
247 if v in vars_dict: 247 if v in vars_dict:
248 gn_args += ' %s=%s' % (v, vars_dict[v]) 248 gn_args += ' %s=%s' % (v, vars_dict[v])
249 249
250 # Some other flags come from GYP environment variables. 250 # Some other flags come from GYP environment variables.
251 gyp_msvs_version = os.environ.get('GYP_MSVS_VERSION', '') 251 gyp_msvs_version = os.environ.get('GYP_MSVS_VERSION', '')
252 if gyp_msvs_version: 252 if gyp_msvs_version:
253 gn_args += ' visual_studio_version=' + EscapeStringForGN(gyp_msvs_version) 253 gn_args += ' visual_studio_version=' + EscapeStringForGN(gyp_msvs_version)
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 # rather than a separate runhooks step so that any environment modifications 492 # rather than a separate runhooks step so that any environment modifications
493 # from above are picked up. 493 # from above are picked up.
494 print 'Running build/landmines.py...' 494 print 'Running build/landmines.py...'
495 subprocess.check_call( 495 subprocess.check_call(
496 [sys.executable, os.path.join(script_dir, 'landmines.py')]) 496 [sys.executable, os.path.join(script_dir, 'landmines.py')])
497 497
498 if vs2013_runtime_dll_dirs: 498 if vs2013_runtime_dll_dirs:
499 CopyVsRuntimeDlls(GetOutputDirectory(), vs2013_runtime_dll_dirs) 499 CopyVsRuntimeDlls(GetOutputDirectory(), vs2013_runtime_dll_dirs)
500 500
501 sys.exit(gyp_rc) 501 sys.exit(gyp_rc)
OLDNEW
« no previous file with comments | « build/config/ios/ios_sdk.gni ('k') | tools/gn/gyp_binary_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698