Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tools/gn/gyp_binary_target_writer.cc

Issue 155983003: GN iOS build fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/gyp_chromium ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/gyp_binary_target_writer.cc
diff --git a/tools/gn/gyp_binary_target_writer.cc b/tools/gn/gyp_binary_target_writer.cc
index eac09ee918c7973d372a98f0f691a84bf656aa1f..d80616ebf01e3ffdfef946b60e36986109f6303d 100644
--- a/tools/gn/gyp_binary_target_writer.cc
+++ b/tools/gn/gyp_binary_target_writer.cc
@@ -483,8 +483,10 @@ void GypBinaryTargetWriter::WriteMacFlags(const Target* target,
} else {
Indent(indent + kExtraIndent) << "'SDKROOT': 'iphoneos',\n";
std::string min_ver = GetIPhoneVersionMin(&flags.cflags);
- if (!min_ver.empty())
- Indent(indent + kExtraIndent) << "'IPHONEOS_DEPLOYMENT_TARGET': '',\n";
+ if (!min_ver.empty()) {
+ Indent(indent + kExtraIndent) << "'IPHONEOS_DEPLOYMENT_TARGET': '"
+ << min_ver << "',\n";
+ }
}
} else {
// When doing regular Mac and "host" iOS (which look like regular Mac)
« no previous file with comments | « build/gyp_chromium ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698