Mark pdfium chromium_code.

Mark pdfium chromium_code.

Now that Chromium's build/common.gypi no longer does weird things
with -Wsign-compare, this should work.

BUG=pdfium:29
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/7397da95d2a543e111327efa7c9142a3fd256230

[Nico, 2016-01-05 16:33:56]

thakis@chromium.org changed reviewers:
+ thestig@chromium.org

[Nico, 2016-01-05 16:33:56]

I did a local build on Linux with this and I'm currently doing a local build on
Windows.

[Lei Zhang, 2016-01-05 17:18:09]

Do we need to update BUILD.gn too?

https://codereview.chromium.org/1557923004/diff/1/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/1557923004/diff/1/pdfium.gyp#newcode59
pdfium.gyp:59: '-Wno-sign-compare',
Remove this guy too?

[Nico, 2016-01-05 17:35:07]

In the gn build, everything's already chromium_code from my last attempt.

https://codereview.chromium.org/1557923004/diff/1/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/1557923004/diff/1/pdfium.gyp#newcode59
pdfium.gyp:59: '-Wno-sign-compare',
On 2016/01/05 17:18:09, Lei Zhang wrote:
> Remove this guy too?

No, this one is needed: pdfium isn't -Wsign-compare clean. The problem was that
build/common.gypi's shenanigans previously made it impossible to disable this
warning on Linux. Now that build/common.gypi doesn't do this anymore, this
warning has an effect and things build.

Removing this flag here will require some code cleanups.

[Lei Zhang, 2016-01-06 00:50:29]

lgtm

https://codereview.chromium.org/1557923004/diff/1/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/1557923004/diff/1/pdfium.gyp#newcode59
pdfium.gyp:59: '-Wno-sign-compare',
On 2016/01/05 17:35:07, Nico wrote:
> On 2016/01/05 17:18:09, Lei Zhang wrote:
> > Remove this guy too?
> 
> No, this one is needed: pdfium isn't -Wsign-compare clean. The problem was
that
> build/common.gypi's shenanigans previously made it impossible to disable this
> warning on Linux. Now that build/common.gypi doesn't do this anymore, this
> warning has an effect and things build.
> 
> Removing this flag here will require some code cleanups.

Acknowledged. "some" code cleanups, probably for a large value of "some".

[Nico, 2016-01-06 01:21:53]

I think I gave it a shot about a year ago and it wasn't _that_ bad (didn't get
it all reviewed though)

Thanks!

[Nico, 2016-01-06 01:23:17]

Description was changed from

==========
Mark pdfium chromium_code.

Now that Chromium's build/common.gypi no longer does weird things
with -Wsign-compare, this should work.

BUG=pdfium:29
==========

to

==========
Mark pdfium chromium_code.

Now that Chromium's build/common.gypi no longer does weird things
with -Wsign-compare, this should work.

BUG=pdfium:29
R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/7397da95d2a543e111327efa7c9142a3fd25...
==========

[Nico, 2016-01-06 01:23:18]

Committed patchset #1 (id:1) manually as
7397da95d2a543e111327efa7c9142a3fd256230 (presubmit successful).