Mark pdfium chromium_code.

pdfium.gyp

 # Copyright 2015 PDFium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
-    # TODO(thakis): Enable this, pdfium:29
-    #'chromium_code': 1,
+    'chromium_code': 1,
     'pdf_use_skia%': 0,
     'pdf_enable_v8%': 1,
     'conditions': [
       ['OS=="linux"', {
         'bundle_freetype%': 0,
       }, {  # On Android there's no system FreeType. On Windows and Mac, only a
             # few methods are used from it.
         'bundle_freetype%': 1,
       }],
     ],
@@ skipping 31 matching lines @@
       }],
     ],
     'msvs_disabled_warnings': [
       4005, 4018, 4146, 4333, 4345, 4267,
       # TODO(thestig): Fix all instances, remove this, pdfium:29
       4245, 4310, 4389, 4701, 4702, 4706, 4800,
     ],
     'variables': {
       'clang_warning_flags': [
         # TODO(thestig): Fix all instances, remove this, pdfium:29
         '-Wno-sign-compare',

[Lei Zhang, 2016/01/05 17:18:09]

Remove this guy too?

[Nico, 2016/01/05 17:35:07]

No, this one is needed: pdfium isn't -Wsign-compare clean. The problem was that
build/common.gypi's shenanigans previously made it impossible to disable this
warning on Linux. Now that build/common.gypi doesn't do this anymore, this
warning has an effect and things build.

Removing this flag here will require some code cleanups.

[Lei Zhang, 2016/01/06 00:50:29]

Acknowledged. "some" code cleanups, probably for a large value of "some".

       ],
-      # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux.
-      'cflags_cc!': [ '-Wsign-compare' ],
     },
   },
   'targets': [
     {
       'target_name': 'pdfium',
       'type': 'static_library',
       'dependencies': [
         'third_party/third_party.gyp:bigint',
         'third_party/third_party.gyp:pdfium_base',
         'fdrm',
@@ skipping 728 matching lines @@
           ],
           'dependencies': [
             '<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
             '<(DEPTH)/v8/tools/gyp/v8.gyp:v8_libplatform',
           ],
         }],
       ],
     },
   ],
 }