Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: pdfium.gyp

Issue 1557923004: Mark pdfium chromium_code. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdfium.gyp
diff --git a/pdfium.gyp b/pdfium.gyp
index 8401dcc5b90b6b88d35af70d0cdbed6ff2b36552..da29bfd796b0af78a60ebcc722e22016256f964b 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -4,8 +4,7 @@
{
'variables': {
- # TODO(thakis): Enable this, pdfium:29
- #'chromium_code': 1,
+ 'chromium_code': 1,
'pdf_use_skia%': 0,
'pdf_enable_v8%': 1,
'conditions': [
@@ -59,8 +58,6 @@
# TODO(thestig): Fix all instances, remove this, pdfium:29
'-Wno-sign-compare',
Lei Zhang 2016/01/05 17:18:09 Remove this guy too?
Nico 2016/01/05 17:35:07 No, this one is needed: pdfium isn't -Wsign-compar
Lei Zhang 2016/01/06 00:50:29 Acknowledged. "some" code cleanups, probably for a
],
- # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux.
- 'cflags_cc!': [ '-Wsign-compare' ],
},
},
'targets': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698