Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1557733002: Prepare for -Wall for third-party code, -Wextra for chromium_code (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, sadrul, vmpstr+watch_chromium.org, posciak+watch_chromium.org, dmazzoni+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, lcwu+watch_chromium.org, jam, je_julie, darin-cc_chromium.org, halliwell+watch_chromium.org, kalyank, android-webview-reviews_chromium.org, tdanderson+views_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, gunsch+watch_chromium.org, Dai Mikurube (NOT FULLTIME), plundblad+watch_chromium.org, wfh+watch_chromium.org, nektar+watch_chromium.org, mcasas+watch_chromium.org, dtseng+watch_chromium.org, tfarina, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare for -Wall for third-party code, -Wextra for chromium_code This lands patch set 16 of https://codereview.chromium.org/1551753002/ (reviewed there), except for the changes to build/common.gypi and build/config/compiler/BUILD.gn. The changes to these two files are likely to break some bot I don't know about, and I don't want to keep reverting and relanding all these files. So this lands the parts that are hopefully harmless separately. BUG=573250 TBR=thestig Committed: https://crrev.com/29de2c811de5e5fa6eb238bbcd45796907c037bd Cr-Commit-Position: refs/heads/master@{#367252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -42 lines) Patch
M android_webview/native/input_stream_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M base/allocator/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
M base/allocator/allocator.gyp View 1 chunk +14 lines, -0 lines 0 comments Download
M base/android/context_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M base/android/context_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/data_usage/tab_data_use_entry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/accessibility_features_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_info.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/crash/linux/dump_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/system/statistics_provider.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/crash/content/app/breakpad_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/android/android_history_types.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/plugin/plugin.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/android/java/gin_java_method_invocation_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/java/gin_java_method_invocation_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/linux/v4l2_capture_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/untrusted/irt_stub/thread_creator.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/android_crazy_linker/src/src/crazy_linker_leb128.h View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/android_protobuf/BUILD.gn View 2 chunks +15 lines, -7 lines 0 comments Download
M third_party/android_protobuf/android_protobuf.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/mach_override/BUILD.gn View 2 chunks +19 lines, -1 line 0 comments Download
M third_party/mach_override/mach_override.gyp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/ocmock/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/ocmock/ocmock.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557733002/1
4 years, 11 months ago (2015-12-31 15:35:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 17:26:15 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/29de2c811de5e5fa6eb238bbcd45796907c037bd Cr-Commit-Position: refs/heads/master@{#367252}
4 years, 11 months ago (2015-12-31 17:27:20 UTC) #7
Nico
4 years, 11 months ago (2015-12-31 22:30:39 UTC) #9
Lei Zhang
4 years, 11 months ago (2015-12-31 23:03:17 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698