Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_leb128.h

Issue 1557733002: Prepare for -Wall for third-party code, -Wextra for chromium_code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/native_client/src/untrusted/irt_stub/thread_creator.c ('k') | third_party/android_protobuf/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/android_crazy_linker/src/src/crazy_linker_leb128.h
diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_leb128.h b/third_party/android_crazy_linker/src/src/crazy_linker_leb128.h
index 787566e66433b9cb7c10b723b96ffccd80d6c1f3..08bea66ee33c20fcb906c72ffcf954202179a6a5 100644
--- a/third_party/android_crazy_linker/src/src/crazy_linker_leb128.h
+++ b/third_party/android_crazy_linker/src/src/crazy_linker_leb128.h
@@ -15,8 +15,11 @@ namespace crazy {
class Sleb128Decoder {
public:
- Sleb128Decoder(const uint8_t* buffer, size_t count)
- : current_(buffer), end_(buffer + count) { }
+ Sleb128Decoder(const uint8_t* buffer, size_t count) : current_(buffer)
+#ifndef NDEBUG
+ , end_(buffer + count)
+#endif
+ {}
size_t pop_front() {
size_t value = 0;
@@ -42,7 +45,9 @@ class Sleb128Decoder {
private:
const uint8_t* current_;
+#ifndef NDEBUG
const uint8_t* const end_;
+#endif
};
} // namespace crazy
« no previous file with comments | « ppapi/native_client/src/untrusted/irt_stub/thread_creator.c ('k') | third_party/android_protobuf/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698