Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: components/nacl/renderer/plugin/plugin.gypi

Issue 1557733002: Prepare for -Wall for third-party code, -Wextra for chromium_code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Native Client Authors. All rights reserved. 1 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, # Use higher warning level. 7 'chromium_code': 1, # Use higher warning level.
8 'common_sources': [ 8 'common_sources': [
9 'module_ppapi.cc', 9 'module_ppapi.cc',
10 'nacl_subprocess.cc', 10 'nacl_subprocess.cc',
(...skipping 15 matching lines...) Expand all
26 ], 26 ],
27 'target_defaults': { 27 'target_defaults': {
28 'variables': { 28 'variables': {
29 'target_platform': 'none', 29 'target_platform': 'none',
30 }, 30 },
31 'conditions': [ 31 'conditions': [
32 ['OS=="linux"', { 32 ['OS=="linux"', {
33 'cflags': [ 33 'cflags': [
34 '-Wno-long-long', 34 '-Wno-long-long',
35 ], 35 ],
36 'cflags!': [
37 '-Wno-unused-parameter', # be a bit stricter to match NaCl flags.
38 ],
39 'conditions': [ 36 'conditions': [
40 ['asan!=1 and msan!=1 and ubsan_vptr!=1', { 37 ['asan!=1 and msan!=1 and ubsan_vptr!=1', {
41 'ldflags': [ 38 'ldflags': [
42 # Catch unresolved symbols. 39 # Catch unresolved symbols.
43 '-Wl,-z,defs', 40 '-Wl,-z,defs',
44 ], 41 ],
45 }], 42 }],
46 ], 43 ],
47 'libraries': [ 44 'libraries': [
48 '-ldl', 45 '-ldl',
(...skipping 24 matching lines...) Expand all
73 'link_settings': { 70 'link_settings': {
74 'libraries': [ 71 'libraries': [
75 '-lgdi32.lib', 72 '-lgdi32.lib',
76 '-luser32.lib', 73 '-luser32.lib',
77 ], 74 ],
78 }, 75 },
79 }], 76 }],
80 ], 77 ],
81 }, 78 },
82 } 79 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698