Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1557693002: Convert Pass()→std::move() in //chrome/browser/chromeos/policy (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //chrome/browser/chromeos/policy (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=atwilson@chromium.org Committed: https://crrev.com/c43fe3f981c45a84313e6afed62e54a7ad71dc2d Cr-Commit-Position: refs/heads/master@{#367231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -168 lines) Patch
M chrome/browser/chromeos/policy/affiliated_cloud_policy_invalidator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_unenrollment_handler_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_provider.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service.cc View 6 chunks +12 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_store.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_network_configuration_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/fake_device_cloud_policy_manager.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/login_profile_policy_provider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/policy/restore_on_startup_browsertest_chromeos.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/status_uploader.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/status_uploader_unittest.cc View 8 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/policy/system_log_uploader.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/system_log_uploader_unittest.cc View 6 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/upload_job_impl.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/upload_job_unittest.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 10 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/user_policy_test_helper.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dcheng
4 years, 11 months ago (2015-12-31 01:05:38 UTC) #1
dcheng
(avi for general review / sanity check, atwilson for OWNERS review)
4 years, 11 months ago (2015-12-31 01:06:06 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557693002/1
4 years, 11 months ago (2015-12-31 01:06:13 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-31 01:32:40 UTC) #6
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-31 04:49:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557693002/1
4 years, 11 months ago (2015-12-31 04:50:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 04:57:43 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 04:59:22 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c43fe3f981c45a84313e6afed62e54a7ad71dc2d
Cr-Commit-Position: refs/heads/master@{#367231}

Powered by Google App Engine
This is Rietveld 408576698