chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc - Issue 1557693002: Convert Pass()→std::move() in //chrome/browser/chromeos/policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

Issue 1557693002: Convert Pass()→std::move() in //chrome/browser/chromeos/policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc ('k') | chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

diff --git a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

index d4cb4a8632ef0ee4a969ab47103f67717e9ba21f..4749636051e633831480cd5cb283685b76ad8ac0 100644

--- a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

+++ b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

@@ -97,7 +97,7 @@ scoped_ptr<net::URLFetcher> FakeURLFetcherFactory::CreateURLFetcher(

net::FakeURLFetcherFactory::CreateURLFetcher(id, url, request_type,

delegate);

EXPECT_TRUE(fetcher);

- return fetcher.Pass();

+ return fetcher;

}

} // namespace

@@ -204,7 +204,7 @@ scoped_ptr<base::DictionaryValue>

metadata->SetStringWithoutPathExpansion("url", url);

metadata->SetStringWithoutPathExpansion("hash", base::HexEncode(hash.c_str(),

hash.size()));

- return metadata.Pass();

+ return metadata;

}

void CloudExternalDataManagerBaseTest::SetExternalDataReference(