chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc - Issue 1557693002: Convert Pass()→std::move() in //chrome/browser/chromeos/policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

Issue 1557693002: Convert Pass()→std::move() in //chrome/browser/chromeos/policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc ('k') | chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

diff --git a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

index 1b1e69987a2d86878de0364229c68b9ca8c83df0..f719de75ed5b17037769f3024b45e89f34aebbb1 100644

--- a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

+++ b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h"

#include <fstream>

+#include <utility>

#include "ash/shell.h"

#include "base/bind.h"

@@ -93,7 +94,7 @@ scoped_ptr<std::string> DeviceCommandScreenshotJob::Payload::Serialize() {

DeviceCommandScreenshotJob::DeviceCommandScreenshotJob(

scoped_ptr<Delegate> screenshot_delegate)

: num_pending_screenshots_(0),

- screenshot_delegate_(screenshot_delegate.Pass()),

+ screenshot_delegate_(std::move(screenshot_delegate)),

weak_ptr_factory_(this) {

DCHECK(screenshot_delegate_);

}

@@ -179,7 +180,7 @@ void DeviceCommandScreenshotJob::StartScreenshotUpload() {

upload_job_->AddDataSegment(

base::StringPrintf(kNameFieldTemplate, screenshot_entry.first),

base::StringPrintf(kFilenameFieldTemplate, screenshot_entry.first),

- header_fields, data.Pass());

+ header_fields, std::move(data));

}

upload_job_->Start();

}