Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: chrome/browser/chromeos/policy/upload_job_unittest.cc

Issue 1557693002: Convert Pass()→std::move() in //chrome/browser/chromeos/policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/policy/upload_job.h" 5 #include "chrome/browser/chromeos/policy/upload_job.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <queue> 9 #include <queue>
10 #include <set> 10 #include <set>
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 void OnFailure(UploadJob::ErrorCode error_code) override { 166 void OnFailure(UploadJob::ErrorCode error_code) override {
167 if (expected_error_ && *expected_error_.get() == error_code) 167 if (expected_error_ && *expected_error_.get() == error_code)
168 run_loop_.Quit(); 168 run_loop_.Quit();
169 else 169 else
170 FAIL(); 170 FAIL();
171 } 171 }
172 172
173 const GURL GetServerURL() const { return test_server_.GetURL(kUploadPath); } 173 const GURL GetServerURL() const { return test_server_.GetURL(kUploadPath); }
174 174
175 void SetExpectedError(scoped_ptr<UploadJob::ErrorCode> expected_error) { 175 void SetExpectedError(scoped_ptr<UploadJob::ErrorCode> expected_error) {
176 expected_error_ = expected_error.Pass(); 176 expected_error_ = std::move(expected_error);
177 } 177 }
178 178
179 // testing::Test: 179 // testing::Test:
180 void SetUp() override { 180 void SetUp() override {
181 request_context_getter_ = new net::TestURLRequestContextGetter( 181 request_context_getter_ = new net::TestURLRequestContextGetter(
182 base::ThreadTaskRunnerHandle::Get()); 182 base::ThreadTaskRunnerHandle::Get());
183 oauth2_service_.AddAccount("robot@gmail.com"); 183 oauth2_service_.AddAccount("robot@gmail.com");
184 ASSERT_TRUE(test_server_.Start()); 184 ASSERT_TRUE(test_server_.Start());
185 } 185 }
186 186
187 // testing::Test: 187 // testing::Test:
188 void TearDown() override { 188 void TearDown() override {
189 ASSERT_TRUE(test_server_.ShutdownAndWaitUntilComplete()); 189 ASSERT_TRUE(test_server_.ShutdownAndWaitUntilComplete());
190 } 190 }
191 191
192 protected: 192 protected:
193 scoped_ptr<UploadJob> PrepareUploadJob(scoped_ptr< 193 scoped_ptr<UploadJob> PrepareUploadJob(scoped_ptr<
194 UploadJobImpl::MimeBoundaryGenerator> mime_boundary_generator) { 194 UploadJobImpl::MimeBoundaryGenerator> mime_boundary_generator) {
195 scoped_ptr<UploadJob> upload_job(new UploadJobImpl( 195 scoped_ptr<UploadJob> upload_job(
196 GetServerURL(), kRobotAccountId, &oauth2_service_, 196 new UploadJobImpl(GetServerURL(), kRobotAccountId, &oauth2_service_,
197 request_context_getter_.get(), this, mime_boundary_generator.Pass())); 197 request_context_getter_.get(), this,
198 std::move(mime_boundary_generator)));
198 199
199 std::map<std::string, std::string> header_entries; 200 std::map<std::string, std::string> header_entries;
200 header_entries.insert(std::make_pair(kCustomField1, "CUSTOM1")); 201 header_entries.insert(std::make_pair(kCustomField1, "CUSTOM1"));
201 scoped_ptr<std::string> data(new std::string(kTestPayload1)); 202 scoped_ptr<std::string> data(new std::string(kTestPayload1));
202 upload_job->AddDataSegment("Name1", "file1.ext", header_entries, 203 upload_job->AddDataSegment("Name1", "file1.ext", header_entries,
203 data.Pass()); 204 std::move(data));
204 205
205 header_entries.insert(std::make_pair(kCustomField2, "CUSTOM2")); 206 header_entries.insert(std::make_pair(kCustomField2, "CUSTOM2"));
206 scoped_ptr<std::string> data2(new std::string(kTestPayload2)); 207 scoped_ptr<std::string> data2(new std::string(kTestPayload2));
207 upload_job->AddDataSegment("Name2", "", header_entries, data2.Pass()); 208 upload_job->AddDataSegment("Name2", "", header_entries, std::move(data2));
208 return upload_job.Pass(); 209 return upload_job;
209 } 210 }
210 211
211 content::TestBrowserThreadBundle test_browser_thread_bundle_; 212 content::TestBrowserThreadBundle test_browser_thread_bundle_;
212 base::RunLoop run_loop_; 213 base::RunLoop run_loop_;
213 net::EmbeddedTestServer test_server_; 214 net::EmbeddedTestServer test_server_;
214 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_; 215 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_;
215 MockOAuth2TokenService oauth2_service_; 216 MockOAuth2TokenService oauth2_service_;
216 217
217 scoped_ptr<UploadJob::ErrorCode> expected_error_; 218 scoped_ptr<UploadJob::ErrorCode> expected_error_;
218 }; 219 };
(...skipping 12 matching lines...) Expand all
231 scoped_ptr<net::test_server::HttpResponse> HandlePostRequest( 232 scoped_ptr<net::test_server::HttpResponse> HandlePostRequest(
232 const net::test_server::HttpRequest& request) { 233 const net::test_server::HttpRequest& request) {
233 EXPECT_TRUE(request.headers.find("Authorization") != request.headers.end()); 234 EXPECT_TRUE(request.headers.find("Authorization") != request.headers.end());
234 const std::string authorization_header = 235 const std::string authorization_header =
235 request.headers.at("Authorization"); 236 request.headers.at("Authorization");
236 scoped_ptr<net::test_server::BasicHttpResponse> response( 237 scoped_ptr<net::test_server::BasicHttpResponse> response(
237 new net::test_server::BasicHttpResponse); 238 new net::test_server::BasicHttpResponse);
238 const size_t pos = authorization_header.find(" "); 239 const size_t pos = authorization_header.find(" ");
239 if (pos == std::string::npos) { 240 if (pos == std::string::npos) {
240 response->set_code(net::HTTP_UNAUTHORIZED); 241 response->set_code(net::HTTP_UNAUTHORIZED);
241 return response.Pass(); 242 return std::move(response);
242 } 243 }
243 244
244 const std::string token = authorization_header.substr(pos + 1); 245 const std::string token = authorization_header.substr(pos + 1);
245 response->set_code(oauth2_service_.IsTokenValid(token) 246 response->set_code(oauth2_service_.IsTokenValid(token)
246 ? net::HTTP_OK 247 ? net::HTTP_OK
247 : net::HTTP_UNAUTHORIZED); 248 : net::HTTP_UNAUTHORIZED);
248 return response.Pass(); 249 return std::move(response);
249 } 250 }
250 }; 251 };
251 252
252 TEST_F(UploadFlowTest, SuccessfulUpload) { 253 TEST_F(UploadFlowTest, SuccessfulUpload) {
253 oauth2_service_.SetTokenValid(kTokenValid); 254 oauth2_service_.SetTokenValid(kTokenValid);
254 oauth2_service_.AddTokenToQueue(kTokenValid); 255 oauth2_service_.AddTokenToQueue(kTokenValid);
255 scoped_ptr<UploadJob> upload_job = PrepareUploadJob( 256 scoped_ptr<UploadJob> upload_job = PrepareUploadJob(
256 make_scoped_ptr(new UploadJobImpl::RandomMimeBoundaryGenerator)); 257 make_scoped_ptr(new UploadJobImpl::RandomMimeBoundaryGenerator));
257 upload_job->Start(); 258 upload_job->Start();
258 run_loop_.Run(); 259 run_loop_.Run();
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 test_server_.RegisterRequestHandler(base::Bind( 301 test_server_.RegisterRequestHandler(base::Bind(
301 &UploadRequestTest::HandlePostRequest, base::Unretained(this))); 302 &UploadRequestTest::HandlePostRequest, base::Unretained(this)));
302 } 303 }
303 304
304 scoped_ptr<net::test_server::HttpResponse> HandlePostRequest( 305 scoped_ptr<net::test_server::HttpResponse> HandlePostRequest(
305 const net::test_server::HttpRequest& request) { 306 const net::test_server::HttpRequest& request) {
306 scoped_ptr<net::test_server::BasicHttpResponse> response( 307 scoped_ptr<net::test_server::BasicHttpResponse> response(
307 new net::test_server::BasicHttpResponse); 308 new net::test_server::BasicHttpResponse);
308 response->set_code(net::HTTP_OK); 309 response->set_code(net::HTTP_OK);
309 EXPECT_EQ(expected_content_, request.content); 310 EXPECT_EQ(expected_content_, request.content);
310 return response.Pass(); 311 return std::move(response);
311 } 312 }
312 313
313 void SetExpectedRequestContent(const std::string& expected_content) { 314 void SetExpectedRequestContent(const std::string& expected_content) {
314 expected_content_ = expected_content; 315 expected_content_ = expected_content;
315 } 316 }
316 317
317 protected: 318 protected:
318 std::string expected_content_; 319 std::string expected_content_;
319 }; 320 };
320 321
(...skipping 15 matching lines...) Expand all
336 "customfield2: CUSTOM2\r\n" 337 "customfield2: CUSTOM2\r\n"
337 "\r\n" 338 "\r\n"
338 "**||--||PAYLOAD2||--||**\r\n--" 339 "**||--||PAYLOAD2||--||**\r\n--"
339 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA--\r\n"); 340 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA--\r\n");
340 341
341 upload_job->Start(); 342 upload_job->Start();
342 run_loop_.Run(); 343 run_loop_.Run();
343 } 344 }
344 345
345 } // namespace policy 346 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698