Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1555993002: Reduce risk of MediaQueryEvaluator-induced leaks. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, kenneth.christiansen, Yoav Weiss, blink-reviews-style_chromium.org, blink-reviews-css, devtools-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce risk of MediaQueryEvaluator-induced leaks. With Oilpan, having MediaQueryEvaluator keep a Persistent<> reference to MediaValues isn't necessary and by doing so, increases the risk of creating inadvertent leaks. Move MediaQueryEvaluator to the heap instead. R=haraken BUG=509911 Committed: https://crrev.com/d856c63c88ce49b660f3a054756a9c2f3303a607 Cr-Commit-Position: refs/heads/master@{#367489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.h View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryMatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555993002/1
4 years, 11 months ago (2016-01-04 18:34:50 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 21:31:28 UTC) #4
sof
please take a look. With r200303 ( https://codereview.chromium.org/1260403002 )'s change to MediaValues, shorting out this ...
4 years, 11 months ago (2016-01-05 06:12:20 UTC) #6
haraken
LGTM
4 years, 11 months ago (2016-01-05 06:14:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555993002/1
4 years, 11 months ago (2016-01-05 06:17:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 06:21:59 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 06:23:03 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d856c63c88ce49b660f3a054756a9c2f3303a607
Cr-Commit-Position: refs/heads/master@{#367489}

Powered by Google App Engine
This is Rietveld 408576698