third_party/WebKit/Source/core/css/MediaQueryMatcher.h - Issue 1555993002: Reduce risk of MediaQueryEvaluator-induced leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/MediaQueryMatcher.h

Issue 1555993002: Reduce risk of MediaQueryEvaluator-induced leaks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/MediaQueryMatcher.h

diff --git a/third_party/WebKit/Source/core/css/MediaQueryMatcher.h b/third_party/WebKit/Source/core/css/MediaQueryMatcher.h

index 81ec1ac105f6eb3a84219cc4f6837dd21705fdfe..d46d3547aea0eac2a7a894a06012a6a9e1bfdba7 100644

--- a/third_party/WebKit/Source/core/css/MediaQueryMatcher.h

+++ b/third_party/WebKit/Source/core/css/MediaQueryMatcher.h

@@ -63,10 +63,10 @@ public:

private:

explicit MediaQueryMatcher(Document&);

- PassOwnPtr<MediaQueryEvaluator> createEvaluator() const;

+ PassOwnPtrWillBeRawPtr<MediaQueryEvaluator> createEvaluator() const;

RawPtrWillBeMember<Document> m_document;

- OwnPtr<MediaQueryEvaluator> m_evaluator;

+ OwnPtrWillBeMember<MediaQueryEvaluator> m_evaluator;

using MediaQueryListSet = WillBeHeapLinkedHashSet<RawPtrWillBeWeakMember<MediaQueryList>>;

MediaQueryListSet m_mediaLists;