third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp - Issue 1555993002: Reduce risk of MediaQueryEvaluator-induced leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp

Issue 1555993002: Reduce risk of MediaQueryEvaluator-induced leaks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp

diff --git a/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp b/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp

index 7579d1f0c1e4dd50c8675b03800ab1d5752aeb04..16479c1d6458fc46d63f0901d24f08a57f694b5c 100644

--- a/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp

+++ b/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp

@@ -53,12 +53,12 @@ void MediaQueryMatcher::documentDetached()

m_evaluator = nullptr;

}

-PassOwnPtr<MediaQueryEvaluator> MediaQueryMatcher::createEvaluator() const

+PassOwnPtrWillBeRawPtr<MediaQueryEvaluator> MediaQueryMatcher::createEvaluator() const

{

if (!m_document || !m_document->frame())

return nullptr;

- return adoptPtr(new MediaQueryEvaluator(m_document->frame()));

+ return adoptPtrWillBeNoop(new MediaQueryEvaluator(m_document->frame()));

}

bool MediaQueryMatcher::evaluate(const MediaQuerySet* media)

@@ -147,6 +147,7 @@ DEFINE_TRACE(MediaQueryMatcher)

{

#if ENABLE(OILPAN)

visitor->trace(m_document);

+ visitor->trace(m_evaluator);

visitor->trace(m_mediaLists);

visitor->trace(m_viewportListeners);

#endif