Chromium Code Reviews

Issue 1260403002: Oilpan: Remove raw pointer to LocalFrame from MediaValuesDynamic (Closed)

Created:
5 years, 4 months ago by keishi
Modified:
5 years, 4 months ago
Reviewers:
haraken, oilpan-reviews, Yuta Kitamura
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Remove raw pointer to LocalFrame from MediaValuesDynamic As it says in the comment MediaValuesDynamic will be released on Document::detach so it should be safe to use RawPtrWillBePersistent. BUG=509911 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200303

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : Added comment #

Patch Set 6 : #

Unified diffs Side-by-side diffs Stats (+65 lines, -48 lines)
M Source/core/css/MediaQueryEvaluator.h View 1 chunk +1 line, -1 line 0 comments
M Source/core/css/MediaQueryEvaluatorTest.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/css/MediaValues.h View 1 chunk +4 lines, -3 lines 0 comments
M Source/core/css/MediaValues.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/css/MediaValuesCached.h View 1 chunk +5 lines, -5 lines 0 comments
M Source/core/css/MediaValuesCached.cpp View 3 chunks +18 lines, -10 lines 0 comments
M Source/core/css/MediaValuesDynamic.h View 2 chunks +6 lines, -5 lines 0 comments
M Source/core/css/MediaValuesDynamic.cpp View 3 chunks +11 lines, -5 lines 0 comments
M Source/core/css/parser/SizesAttributeParser.h View 2 chunks +2 lines, -2 lines 0 comments
M Source/core/css/parser/SizesAttributeParser.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/css/parser/SizesAttributeParserTest.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/css/parser/SizesCalcParser.h View 2 chunks +3 lines, -3 lines 0 comments
M Source/core/css/parser/SizesCalcParser.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/css/parser/SizesCalcParserTest.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/html/parser/HTMLPreloadScanner.h View 1 chunk +3 lines, -3 lines 0 comments
M Source/core/html/parser/HTMLPreloadScanner.cpp View 3 chunks +4 lines, -3 lines 0 comments
M Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 10 (2 generated)
keishi
PTAL
5 years, 4 months ago (2015-07-29 21:18:17 UTC) #2
haraken
https://codereview.chromium.org/1260403002/diff/1/Source/core/css/MediaValuesDynamic.h File Source/core/css/MediaValuesDynamic.h (right): https://codereview.chromium.org/1260403002/diff/1/Source/core/css/MediaValuesDynamic.h#newcode46 Source/core/css/MediaValuesDynamic.h:46: RawPtrWillBePersistent<LocalFrame> m_frame; If the RawPtrWillBePersistent doesn't cause a cycle, ...
5 years, 4 months ago (2015-07-30 06:08:58 UTC) #3
keishi
https://codereview.chromium.org/1260403002/diff/1/Source/core/css/MediaValuesDynamic.h File Source/core/css/MediaValuesDynamic.h (right): https://codereview.chromium.org/1260403002/diff/1/Source/core/css/MediaValuesDynamic.h#newcode46 Source/core/css/MediaValuesDynamic.h:46: RawPtrWillBePersistent<LocalFrame> m_frame; On 2015/07/30 06:08:58, haraken wrote: > > ...
5 years, 4 months ago (2015-08-06 06:48:49 UTC) #4
haraken
LGTM https://codereview.chromium.org/1260403002/diff/60001/Source/core/css/MediaValuesCached.cpp File Source/core/css/MediaValuesCached.cpp (right): https://codereview.chromium.org/1260403002/diff/60001/Source/core/css/MediaValuesCached.cpp#newcode93 Source/core/css/MediaValuesCached.cpp:93: return true; Worth having a comment on why ...
5 years, 4 months ago (2015-08-06 08:54:34 UTC) #5
keishi
https://codereview.chromium.org/1260403002/diff/60001/Source/core/css/MediaValuesCached.cpp File Source/core/css/MediaValuesCached.cpp (right): https://codereview.chromium.org/1260403002/diff/60001/Source/core/css/MediaValuesCached.cpp#newcode93 Source/core/css/MediaValuesCached.cpp:93: return true; On 2015/08/06 08:54:34, haraken wrote: > > ...
5 years, 4 months ago (2015-08-10 06:50:46 UTC) #6
haraken
On 2015/08/10 06:50:46, keishi wrote: > https://codereview.chromium.org/1260403002/diff/60001/Source/core/css/MediaValuesCached.cpp > File Source/core/css/MediaValuesCached.cpp (right): > > https://codereview.chromium.org/1260403002/diff/60001/Source/core/css/MediaValuesCached.cpp#newcode93 > ...
5 years, 4 months ago (2015-08-10 07:01:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260403002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260403002/100001
5 years, 4 months ago (2015-08-11 04:55:38 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 06:12:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200303

Powered by Google App Engine