Revert of GN: Properly mark all NaCl test depencies as data_deps

Revert of GN: Properly mark all NaCl test depencies as data_deps (patchset #2 id:20001 of https://codereview.chromium.org/1547463004/ )

Reason for revert:
broke windows GN build:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/9754/steps/generate_build_files/logs/stdio

E:\b\build\slave\Win_x64_GN\build\src\buildtools\win\gn gen //out/Release_x64 "--args=is_debug=false is_component_build=false use_goma=true goma_dir=\"E:\b\build\goma\" symbol_level=1" --check
  -> returned 1
ERROR Input to target not generated by a dependency.
The file:
  //out/Release_x64/nacl_irt_x86_64.nexe
is listed as an input or source for the target:
  //chrome/installer/mini_installer:archive(//build/toolchain/win:x64)
but this file was not generated by any dependencies of the target. The target
that generates the file is:
  //ppapi/native_client:nacl_irt_debuglink(//build/toolchain/nacl:irt_x64)

Original issue's description:
> GN: Properly mark all NaCl test depencies as data_deps
>
> NaCl tests and helpers are build as standalone executables and
> hence need to be marked as data_deps to be copied over to shards.
>
> BUG=462791
>
> Committed: https://crrev.com/21255d8b9b0ace0629fd941ee128cf9adf356b31
> Cr-Commit-Position: refs/heads/master@{#367367}

TBR=brettw@chromium.org,bradnelson@chromium.org,phosek@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462791
Committed: https://crrev.com/65423bc9e6cb679ada9d00d0f41d3ee2d46ffc7c
Cr-Commit-Position: refs/heads/master@{#367396}

[Dan Beam, 2016-01-04 22:49:11]

Created Revert of GN: Properly mark all NaCl test depencies as data_deps

[commit-bot: I haz the power, 2016-01-04 22:51:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555223002/1

[commit-bot: I haz the power, 2016-01-04 22:53:02]

Description was changed from

==========
Revert of GN: Properly mark all NaCl test depencies as data_deps (patchset #2
id:20001 of https://codereview.chromium.org/1547463004/ )

Reason for revert:
broke windows GN build:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/9754...

E:\b\build\slave\Win_x64_GN\build\src\buildtools\win\gn gen //out/Release_x64
"--args=is_debug=false is_component_build=false use_goma=true
goma_dir=\"E:\b\build\goma\" symbol_level=1" --check
  -> returned 1
ERROR Input to target not generated by a dependency.
The file:
  //out/Release_x64/nacl_irt_x86_64.nexe
is listed as an input or source for the target:
  //chrome/installer/mini_installer:archive(//build/toolchain/win:x64)
but this file was not generated by any dependencies of the target. The target
that generates the file is:
  //ppapi/native_client:nacl_irt_debuglink(//build/toolchain/nacl:irt_x64)

Original issue's description:
> GN: Properly mark all NaCl test depencies as data_deps
> 
> NaCl tests and helpers are build as standalone executables and
> hence need to be marked as data_deps to be copied over to shards.
> 
> BUG=462791
> 
> Committed: https://crrev.com/21255d8b9b0ace0629fd941ee128cf9adf356b31
> Cr-Commit-Position: refs/heads/master@{#367367}

TBR=brettw@chromium.org,bradnelson@chromium.org,phosek@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462791
==========

to

==========
Revert of GN: Properly mark all NaCl test depencies as data_deps (patchset #2
id:20001 of https://codereview.chromium.org/1547463004/ )

Reason for revert:
broke windows GN build:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/9754...

E:\b\build\slave\Win_x64_GN\build\src\buildtools\win\gn gen //out/Release_x64
"--args=is_debug=false is_component_build=false use_goma=true
goma_dir=\"E:\b\build\goma\" symbol_level=1" --check
  -> returned 1
ERROR Input to target not generated by a dependency.
The file:
  //out/Release_x64/nacl_irt_x86_64.nexe
is listed as an input or source for the target:
  //chrome/installer/mini_installer:archive(//build/toolchain/win:x64)
but this file was not generated by any dependencies of the target. The target
that generates the file is:
  //ppapi/native_client:nacl_irt_debuglink(//build/toolchain/nacl:irt_x64)

Original issue's description:
> GN: Properly mark all NaCl test depencies as data_deps
> 
> NaCl tests and helpers are build as standalone executables and
> hence need to be marked as data_deps to be copied over to shards.
> 
> BUG=462791
> 
> Committed: https://crrev.com/21255d8b9b0ace0629fd941ee128cf9adf356b31
> Cr-Commit-Position: refs/heads/master@{#367367}

TBR=brettw@chromium.org,bradnelson@chromium.org,phosek@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462791
==========

[commit-bot: I haz the power, 2016-01-04 22:53:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-04 22:54:00]

Description was changed from

==========
Revert of GN: Properly mark all NaCl test depencies as data_deps (patchset #2
id:20001 of https://codereview.chromium.org/1547463004/ )

Reason for revert:
broke windows GN build:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/9754...

E:\b\build\slave\Win_x64_GN\build\src\buildtools\win\gn gen //out/Release_x64
"--args=is_debug=false is_component_build=false use_goma=true
goma_dir=\"E:\b\build\goma\" symbol_level=1" --check
  -> returned 1
ERROR Input to target not generated by a dependency.
The file:
  //out/Release_x64/nacl_irt_x86_64.nexe
is listed as an input or source for the target:
  //chrome/installer/mini_installer:archive(//build/toolchain/win:x64)
but this file was not generated by any dependencies of the target. The target
that generates the file is:
  //ppapi/native_client:nacl_irt_debuglink(//build/toolchain/nacl:irt_x64)

Original issue's description:
> GN: Properly mark all NaCl test depencies as data_deps
> 
> NaCl tests and helpers are build as standalone executables and
> hence need to be marked as data_deps to be copied over to shards.
> 
> BUG=462791
> 
> Committed: https://crrev.com/21255d8b9b0ace0629fd941ee128cf9adf356b31
> Cr-Commit-Position: refs/heads/master@{#367367}

TBR=brettw@chromium.org,bradnelson@chromium.org,phosek@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462791
==========

to

==========
Revert of GN: Properly mark all NaCl test depencies as data_deps (patchset #2
id:20001 of https://codereview.chromium.org/1547463004/ )

Reason for revert:
broke windows GN build:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/9754...

E:\b\build\slave\Win_x64_GN\build\src\buildtools\win\gn gen //out/Release_x64
"--args=is_debug=false is_component_build=false use_goma=true
goma_dir=\"E:\b\build\goma\" symbol_level=1" --check
  -> returned 1
ERROR Input to target not generated by a dependency.
The file:
  //out/Release_x64/nacl_irt_x86_64.nexe
is listed as an input or source for the target:
  //chrome/installer/mini_installer:archive(//build/toolchain/win:x64)
but this file was not generated by any dependencies of the target. The target
that generates the file is:
  //ppapi/native_client:nacl_irt_debuglink(//build/toolchain/nacl:irt_x64)

Original issue's description:
> GN: Properly mark all NaCl test depencies as data_deps
>
> NaCl tests and helpers are build as standalone executables and
> hence need to be marked as data_deps to be copied over to shards.
>
> BUG=462791
>
> Committed: https://crrev.com/21255d8b9b0ace0629fd941ee128cf9adf356b31
> Cr-Commit-Position: refs/heads/master@{#367367}

TBR=brettw@chromium.org,bradnelson@chromium.org,phosek@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462791

Committed: https://crrev.com/65423bc9e6cb679ada9d00d0f41d3ee2d46ffc7c
Cr-Commit-Position: refs/heads/master@{#367396}
==========

[commit-bot: I haz the power, 2016-01-04 22:54:00]

Patchset 1 (id:??) landed as
https://crrev.com/65423bc9e6cb679ada9d00d0f41d3ee2d46ffc7c
Cr-Commit-Position: refs/heads/master@{#367396}