Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Side by Side Diff: extensions/shell/BUILD.gn

Issue 1555223002: Revert of GN: Properly mark all NaCl test depencies as data_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/nacl/loader/BUILD.gn ('k') | ppapi/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//extensions/shell/app_shell.gni") 5 import("//extensions/shell/app_shell.gni")
6 6
7 # Technically, this directory should not depend on files from src/chrome, but 7 # Technically, this directory should not depend on files from src/chrome, but
8 # that's where the VERSION file is. This should probably all be moved to 8 # that's where the VERSION file is. This should probably all be moved to
9 # src/build. 9 # src/build.
10 import("//chrome/version.gni") 10 import("//chrome/version.gni")
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 97
98 deps += [ 98 deps += [
99 "//components/nacl/browser", 99 "//components/nacl/browser",
100 "//components/nacl/common", 100 "//components/nacl/common",
101 "//components/nacl/loader", 101 "//components/nacl/loader",
102 "//components/nacl/renderer", 102 "//components/nacl/renderer",
103 "//components/nacl/renderer/plugin:nacl_trusted_plugin", 103 "//components/nacl/renderer/plugin:nacl_trusted_plugin",
104 ] 104 ]
105 105
106 if (is_linux) { 106 if (is_linux) {
107 deps += [ 107 deps += [ "//components/nacl/loader:nacl_helper" ]
108 "//components/nacl/loader:helper_nonsfi",
109 "//components/nacl/loader:nacl_helper",
110 ]
111 } 108 }
112 } 109 }
113 110
114 if (cld_version == 2) { 111 if (cld_version == 2) {
115 deps += [ "//third_party/cld_2:cld2_platform_impl" ] 112 deps += [ "//third_party/cld_2:cld2_platform_impl" ]
116 } 113 }
117 } 114 }
118 115
119 if (!(is_chromeos && !use_ozone)) { 116 if (!(is_chromeos && !use_ozone)) {
120 executable("app_shell") { 117 executable("app_shell") {
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 testonly = true 229 testonly = true
233 sources = [ 230 sources = [
234 "app/shell_main_mac.cc", 231 "app/shell_main_mac.cc",
235 "app/shell_main_mac.h", 232 "app/shell_main_mac.h",
236 ] 233 ]
237 deps = [ 234 deps = [
238 ":app_shell_lib", 235 ":app_shell_lib",
239 ] 236 ]
240 } 237 }
241 } 238 }
OLDNEW
« no previous file with comments | « components/nacl/loader/BUILD.gn ('k') | ppapi/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698