Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Side by Side Diff: components/nacl/loader/BUILD.gn

Issue 1555223002: Revert of GN: Properly mark all NaCl test depencies as data_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/data/nacl/BUILD.gn ('k') | extensions/shell/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/nacl/config.gni") 6 import("//build/config/nacl/config.gni")
7 import("//testing/test.gni") 7 import("//testing/test.gni")
8 8
9 assert(enable_nacl) 9 assert(enable_nacl)
10 10
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 sources = [ 133 sources = [
134 "nonsfi/nacl_helper_nonsfi_unittests.cc", 134 "nonsfi/nacl_helper_nonsfi_unittests.cc",
135 ] 135 ]
136 deps = [ 136 deps = [
137 "//base", 137 "//base",
138 "//base/test:test_launcher_nacl_nonsfi", 138 "//base/test:test_launcher_nacl_nonsfi",
139 ] 139 ]
140 } 140 }
141 141
142 group("helper_nonsfi") { 142 group("helper_nonsfi") {
143 data_deps = [ 143 deps = [
144 ":nacl_helper_nonsfi_copy(//build/toolchain/nacl:newlib_pnacl_nonsfi)", 144 ":nacl_helper_nonsfi_copy(//build/toolchain/nacl:newlib_pnacl_nonsfi)",
145 ] 145 ]
146 } 146 }
147 147
148 group("helper_nonsfi_unittests") { 148 group("helper_nonsfi_unittests") {
149 testonly = true 149 testonly = true
150 data_deps = [ 150 data_deps = [
151 ":nacl_helper_nonsfi_unittests", 151 ":nacl_helper_nonsfi_unittests",
152 ":nacl_helper_nonsfi_unittests_main_copy(//build/toolchain/nacl:newlib_pna cl_nonsfi)", 152 ":nacl_helper_nonsfi_unittests_main_copy(//build/toolchain/nacl:newlib_pna cl_nonsfi)",
153 ] 153 ]
154 } 154 }
155 155
156 # TODO(GYP): Delete this after we've converted everything to GN. 156 # TODO(GYP): Delete this after we've converted everything to GN.
157 # The _run targets exist only for compatibility w/ GYP. 157 # The _run targets exist only for compatibility w/ GYP.
158 group("nacl_helper_nonsfi_unittests_run") { 158 group("nacl_helper_nonsfi_unittests_run") {
159 testonly = true 159 testonly = true
160 data_deps = [ 160 data_deps = [
161 ":helper_nonsfi_unittests", 161 ":helper_nonsfi_unittests",
162 ":nacl_helper_nonsfi_unittests_main_copy(//build/toolchain/nacl:newlib_pna cl_nonsfi)",
163 ] 162 ]
164 } 163 }
165 } 164 }
166 165
167 if (is_nacl_nonsfi) { 166 if (is_nacl_nonsfi) {
168 executable("nacl_helper_nonsfi_nexe") { 167 executable("nacl_helper_nonsfi_nexe") {
169 output_name = "nacl_helper_nonsfi" 168 output_name = "nacl_helper_nonsfi"
170 set_sources_assignment_filter([]) 169 set_sources_assignment_filter([])
171 sources = [ 170 sources = [
172 # TODO(brettw) can this just depend on //components/nacl/common? 171 # TODO(brettw) can this just depend on //components/nacl/common?
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 "${root_out_dir}/nacl_helper_nonsfi_unittests_main", 260 "${root_out_dir}/nacl_helper_nonsfi_unittests_main",
262 ] 261 ]
263 outputs = [ 262 outputs = [
264 "${root_build_dir}/{{source_file_part}}", 263 "${root_build_dir}/{{source_file_part}}",
265 ] 264 ]
266 deps = [ 265 deps = [
267 ":nacl_helper_nonsfi_unittests_main", 266 ":nacl_helper_nonsfi_unittests_main",
268 ] 267 ]
269 } 268 }
270 } 269 }
OLDNEW
« no previous file with comments | « chrome/test/data/nacl/BUILD.gn ('k') | extensions/shell/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698