Revert of GN: Properly mark all NaCl test depencies as data_deps

ppapi/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 assert(!is_android || enable_plugins,
        "//ppapi should not be referenced when is_android && !enable_plugins")
 
 copy("copy_test_files") {
   visibility = [ ":*" ]
   sources = [
@@ skipping 175 matching lines @@
     "lib/gl/gles2/gles2.c",
   ]
   deps = [
     "//ppapi/cpp",
   ]
 }
 
 if (enable_nacl) {
   if (is_nacl) {
     shared_library("ppapi_cpp_lib_shared") {
-      output_name = "libppapi_cpp"
-
       # When using gcc, we hide all symbols by default, but that breaks at
       # link time as the test executable requires symbols defined in the
       # shared library.
       if (is_nacl_glibc) {
         configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
       }
 
       sources = ppapi_sources.cpp_source_files
       sources += [
         "cpp/module_embedder.h",
         "cpp/ppp_entrypoints.cc",
       ]
       cflags = [ "-fPIC" ]
       deps = [
         "//build/config/nacl:nacl_base",
       ]
     }
 
-    executable("ppapi_nacl_tests_nexe") {
-      output_name = "ppapi_nacl_tests"
+    executable("ppapi_nacl_tests") {
       include_dirs = [ "lib/gl/include" ]
       sources = ppapi_sources.test_common_source_files +
                 ppapi_sources.test_nacl_source_files
       defines = [
         "GL_GLEXT_PROTOTYPES",
         "PPAPI_TEST_IMPLEMENTATION",
       ]
       ldflags = [ "-pthread" ]
       deps = [
         "//build/config/nacl:nacl_base",
         "//ppapi/native_client:ppapi_lib",
       ]
       if (is_nacl_glibc) {
         deps += [ ":ppapi_cpp_lib_shared" ]
       } else {
         deps += [ ":ppapi_cpp_lib" ]
       }
     }
 
     if (current_cpu == "pnacl") {
       action("translate_pexe_to_nexe") {
         # We specify the toolchain explicitly because in the Non-SFI case, we
         # still want to use the pexe built using the newlib_pnacl toolchain.
-        tests = ":ppapi_nacl_tests_nexe(//build/toolchain/nacl:newlib_pnacl)"
+        tests = ":ppapi_nacl_tests(//build/toolchain/nacl:newlib_pnacl)"
 
         pexe = get_label_info(tests, "root_out_dir") + "/ppapi_nacl_tests.pexe"
         nexe = "${root_out_dir}/ppapi_nacl_tests.nexe"
 
         script = "${nacl_toolchain_bindir}/pydir/loader.py"
         sources = [
           pexe,
         ]
         outputs = [
           nexe,
@@ skipping 39 matching lines @@
         ]
         deps = [
           tests,
         ]
         data_deps = [
           pnacl_irt_shim,
         ]
       }
     }
 
-    copy("ppapi_nacl_tests_copy") {
+    copy("nacl_tests_copy") {
       sources = [
         "${root_out_dir}/ppapi_nacl_tests.nexe",
       ]
 
       # The CPU names used in tests/ppapi_nacl_tests_newlib.nmf
       # are the ones used in GYP (x32 for x86).
-      if (target_cpu == "x86" ||
-          (is_nacl_nonsfi && (target_cpu == "x86" || target_cpu == "x64"))) {
-        nmf_cpu = "x32"
+      if (current_cpu == "pnacl") {
+        suffix = "pnacl"
       } else {
-        nmf_cpu = target_cpu
-      }
-      if (current_cpu == "pnacl") {
-        if (is_nacl_nonsfi) {
-          suffix = "pnacl_newlib_${nmf_cpu}_nonsfi"
+        if (target_cpu == "x86") {
+          nmf_cpu = "x32"
         } else {
-          suffix = "pnacl_newlib_${nmf_cpu}"
+          nmf_cpu = target_cpu
         }
-      } else if (is_nacl_glibc) {
-        suffix = "glibc_${nmf_cpu}"
-      } else {
-        suffix = "newlib_${nmf_cpu}"
+        if (is_nacl_glibc) {
+          suffix = "glibc_${nmf_cpu}"
+        } else {
+          suffix = "newlib_${nmf_cpu}"
+        }
       }
       outputs = [
         "${root_build_dir}/{{source_name_part}}_${suffix}.nexe",
       ]
       if (current_cpu == "pnacl") {
         deps = [
           ":translate_pexe_to_nexe",
         ]
       } else {
         deps = [
-          ":ppapi_nacl_tests_nexe",
+          ":ppapi_nacl_tests",
         ]
       }
     }
 
-    if (is_nacl_nonsfi) {
-      generate_nonsfi_test_nmf("ppapi_nacl_tests_nmf") {
-        nmf = "${root_build_dir}/ppapi_nacl_tests_pnacl_nonsfi.nmf"
-        files = get_target_outputs(":ppapi_nacl_tests_copy")
-        executable = files[0]
-        deps = [
-          ":ppapi_nacl_tests_copy",
-        ]
+    generate_nmf("ppapi_nacl_tests_nmf") {
+      if (is_nacl_glibc) {
+        nmf = "${root_build_dir}/ppapi_nacl_tests_glibc.nmf"
+        stage_dependencies = root_build_dir
+      } else if (current_cpu == "pnacl") {
+        nmf = "${root_build_dir}/ppapi_nacl_tests_pnacl.nmf"
+      } else {
+        nmf = "${root_build_dir}/ppapi_nacl_tests_newlib.nmf"
       }
-    } else {
-      generate_nmf("ppapi_nacl_tests_nmf") {
-        if (is_nacl_glibc) {
-          nmf = "${root_build_dir}/ppapi_nacl_tests_glibc.nmf"
-          stage_dependencies = root_build_dir
-        } else if (current_cpu == "pnacl") {
-          nmf = "${root_build_dir}/ppapi_nacl_tests_pnacl.nmf"
-        } else {
-          nmf = "${root_build_dir}/ppapi_nacl_tests_newlib.nmf"
-        }
-        executables = get_target_outputs(":ppapi_nacl_tests_copy")
-        deps = [
-          ":ppapi_nacl_tests_copy",
-        ]
-      }
+      executables = get_target_outputs(":nacl_tests_copy")
+      deps = [
+        ":nacl_tests_copy",
+      ]
     }
 
-    group("ppapi_nacl_tests") {
-      data_deps = [
-        ":ppapi_nacl_tests_copy",
-        ":ppapi_nacl_tests_nmf",
+    generate_nonsfi_test_nmf("ppapi_nacl_tests_pnacl_nonsfi_nmf") {
+      nmf = "${root_build_dir}/ppapi_nacl_tests_pnacl_nonsfi.nmf"
+      executable = "${root_out_dir}/ppapi_nacl_tests.nexe"
+      deps = [
+        ":translate_pexe_to_nexe",
       ]
     }
   }
 
   group("ppapi_nacl_tests_all") {
     data_deps = [
       ":copy_test_files",
-      ":ppapi_nacl_tests_copy(//build/toolchain/nacl:clang_newlib_${target_cpu})",
-      ":ppapi_nacl_tests(//build/toolchain/nacl:glibc_${target_cpu})",
+      ":nacl_tests_copy(//build/toolchain/nacl:clang_newlib_${target_cpu})",
+      ":ppapi_nacl_tests_nmf(//build/toolchain/nacl:glibc_${target_cpu})",
     ]
     if (enable_pnacl) {
       data_deps += [
-        ":ppapi_nacl_tests(//build/toolchain/nacl:newlib_pnacl)",
-        ":ppapi_nacl_tests(//build/toolchain/nacl:newlib_pnacl_nonsfi)",
+        ":ppapi_nacl_tests_nmf(//build/toolchain/nacl:newlib_pnacl)",
+        ":ppapi_nacl_tests_pnacl_nonsfi_nmf(//build/toolchain/nacl:newlib_pnacl_nonsfi)",
       ]
     }
   }
 }