Update to latest analyzer

Update to latest analyzer

Fixes https://github.com/dart-lang/dev_compiler/issues/393

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/5613a6a8ad86cd79d03c12d642013cbe5bd556d6

[Leaf, 2015-12-30 19:11:51]

Description was changed from

==========
Update to latest analyzer

BUG=
==========

to

==========
Update to latest analyzer

Fixes https://github.com/dart-lang/dev_compiler/issues/393

BUG=
==========

[Jennifer Messerly, 2016-01-04 20:48:39]

jmesserly@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2016-01-04 20:48:40]

Not sure if you were ready to send it out yet :)

But LGTM other than the error levels being wrong--I think it just needs a few
tiny fixes in report.dart

https://codereview.chromium.org/1554683002/diff/60001/lib/src/codegen/js_code...
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1554683002/diff/60001/lib/src/codegen/js_code...
lib/src/codegen/js_codegen.dart:3501: // be shared somewhere.
yeah, agree. Another idea is we could just store it in the resolved AST. Doesn't
seem unreasonable to ask what the T is in a sync*/async/async* method.

https://codereview.chromium.org/1554683002/diff/60001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1554683002/diff/60001/pubspec.yaml#newcode30
pubspec.yaml:30: analyzer: { path: ../../dart-repo/sdk/pkg/analyzer }
guessing you were going to revert this before check in. if so no reply needed :)

https://codereview.chromium.org/1554683002/diff/60001/test/codegen/expect/col...
File test/codegen/expect/collection/algorithms.txt (right):

https://codereview.chromium.org/1554683002/diff/60001/test/codegen/expect/col...
test/codegen/expect/collection/algorithms.txt:2: severe: [AnalyzerMessage]
sortedList (List<dynamic>) will need runtime check to cast to type
List<Comparable<dynamic>> (package:collection/algorithms.dart, line 44, col 36)
is this error level still correct? it looks like we are incorrectly promoting a
Strong Mode Warning into an Error.

this might be happening because of:
https://github.com/dart-lang/dev_compiler/blob/9b5978cb4c89f801b781a96a8d67e3...

https://codereview.chromium.org/1554683002/diff/60001/test/codegen/expect/col...
File test/codegen/expect/collection/equality.txt (right):

https://codereview.chromium.org/1554683002/diff/60001/test/codegen/expect/col...
test/codegen/expect/collection/equality.txt:3: severe: [AnalyzerMessage] Type
check failed: const DefaultEquality() (DefaultEquality) is not of type
Equality<E> because const DefaultEquality() cannot be typed as Equality<E>
(package:collection/equality.dart, line 75, col 31)
Now that all of our errors include [AnalyzerMessage], we could remove the
redundant "[AnalyzerMessage]" text right?

I believe it comes from here:
https://github.com/dart-lang/dev_compiler/blob/9b5978cb4c89f801b781a96a8d67e3...

[Leaf, 2016-01-04 21:34:46]

leafp@google.com changed reviewers:
+ vsm@google.com

[Leaf, 2016-01-04 21:34:47]

Was mostly ready to go. :)  There were a few changes that went in after John's
first look, and I've addressed John's comments modulo the question of whether we
want to keep tagging the error messages as coming from the Analyzer vs our own
tags.  

Vijay - I didn't tackle dart:html and dart:html_common at all, since I presume
that needs to be addressed in the generator scripts.  I think there are some new
errors there due to generic methods in superclasses (e.g. things that implement
List).

https://codereview.chromium.org/1554683002/diff/60001/lib/src/codegen/js_code...
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1554683002/diff/60001/lib/src/codegen/js_code...
lib/src/codegen/js_codegen.dart:3501: // be shared somewhere.
On 2016/01/04 20:48:40, John Messerly wrote:
> yeah, agree. Another idea is we could just store it in the resolved AST.
Doesn't
> seem unreasonable to ask what the T is in a sync*/async/async* method.

Acknowledged.

https://codereview.chromium.org/1554683002/diff/60001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1554683002/diff/60001/pubspec.yaml#newcode30
pubspec.yaml:30: analyzer: { path: ../../dart-repo/sdk/pkg/analyzer }
On 2016/01/04 20:48:40, John Messerly wrote:
> guessing you were going to revert this before check in. if so no reply needed
:)

Acknowledged.

https://codereview.chromium.org/1554683002/diff/60001/test/codegen/expect/col...
File test/codegen/expect/collection/algorithms.txt (right):

https://codereview.chromium.org/1554683002/diff/60001/test/codegen/expect/col...
test/codegen/expect/collection/algorithms.txt:2: severe: [AnalyzerMessage]
sortedList (List<dynamic>) will need runtime check to cast to type
List<Comparable<dynamic>> (package:collection/algorithms.dart, line 44, col 36)
On 2016/01/04 20:48:40, John Messerly wrote:
> is this error level still correct? it looks like we are incorrectly promoting
a
> Strong Mode Warning into an Error.
> 
> this might be happening because of:
>
https://github.com/dart-lang/dev_compiler/blob/9b5978cb4c89f801b781a96a8d67e3...

Ah right.  I meant to look into that, thanks for the pointer.  Fixed now, and
re-factored to avoid having to track down all the different pattern matches.

https://codereview.chromium.org/1554683002/diff/60001/test/codegen/expect/col...
File test/codegen/expect/collection/equality.txt (right):

https://codereview.chromium.org/1554683002/diff/60001/test/codegen/expect/col...
test/codegen/expect/collection/equality.txt:3: severe: [AnalyzerMessage] Type
check failed: const DefaultEquality() (DefaultEquality) is not of type
Equality<E> because const DefaultEquality() cannot be typed as Equality<E>
(package:collection/equality.dart, line 75, col 31)
On 2016/01/04 20:48:40, John Messerly wrote:
> Now that all of our errors include [AnalyzerMessage], we could remove the
> redundant "[AnalyzerMessage]" text right?
> 
> I believe it comes from here:
>
https://github.com/dart-lang/dev_compiler/blob/9b5978cb4c89f801b781a96a8d67e3...

They actually don't - I'd just missed this pattern match against 'dev_compiler.'
as well.  I've changed it to restore the old behavior, but I'm open to getting
rid of the classification tag.  Take a look, see what you think.

[Jennifer Messerly, 2016-01-04 22:17:31]

I looked at the two new patch sets, they LGTM!

https://codereview.chromium.org/1554683002/diff/100001/lib/src/utils.dart
File lib/src/utils.dart (right):

https://codereview.chromium.org/1554683002/diff/100001/lib/src/utils.dart#new...
lib/src/utils.dart:414: return
(errorCode.name.startsWith(_strongModeErrorPrefix));
trivial: parens not needed around the return expression

https://codereview.chromium.org/1554683002/diff/100001/test/codegen/expect/co...
File test/codegen/expect/collection/equality.txt (right):

https://codereview.chromium.org/1554683002/diff/100001/test/codegen/expect/co...
test/codegen/expect/collection/equality.txt:3: severe: [_STATIC_TYPE_ERROR] Type
check failed: const DefaultEquality() (DefaultEquality) is not of type
Equality<E> because const DefaultEquality() cannot be typed as Equality<E>
(package:collection/equality.dart, line 75, col 31)
remove leading underscore? up to you :)

[Leaf, 2016-01-04 23:26:16]

https://codereview.chromium.org/1554683002/diff/100001/lib/src/utils.dart
File lib/src/utils.dart (right):

https://codereview.chromium.org/1554683002/diff/100001/lib/src/utils.dart#new...
lib/src/utils.dart:414: return
(errorCode.name.startsWith(_strongModeErrorPrefix));
On 2016/01/04 22:17:31, John Messerly wrote:
> trivial: parens not needed around the return expression

Done.

https://codereview.chromium.org/1554683002/diff/100001/test/codegen/expect/co...
File test/codegen/expect/collection/equality.txt (right):

https://codereview.chromium.org/1554683002/diff/100001/test/codegen/expect/co...
test/codegen/expect/collection/equality.txt:3: severe: [_STATIC_TYPE_ERROR] Type
check failed: const DefaultEquality() (DefaultEquality) is not of type
Equality<E> because const DefaultEquality() cannot be typed as Equality<E>
(package:collection/equality.dart, line 75, col 31)
On 2016/01/04 22:17:31, John Messerly wrote:
> remove leading underscore? up to you :)

Done.

[Leaf, 2016-01-05 23:58:55]

Description was changed from

==========
Update to latest analyzer

Fixes https://github.com/dart-lang/dev_compiler/issues/393

BUG=
==========

to

==========
Update to latest analyzer

Fixes https://github.com/dart-lang/dev_compiler/issues/393

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/5613a6a8ad86cd79d03c12d64201...
==========

[Leaf, 2016-01-05 23:58:56]

Committed patchset #8 (id:140001) manually as
5613a6a8ad86cd79d03c12d642013cbe5bd556d6 (presubmit successful).