Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tool/input_sdk/lib/async/future.dart

Issue 1554683002: Update to latest analyzer (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/analyze.sh ('k') | tool/input_sdk/lib/async/future_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/lib/async/future.dart
diff --git a/tool/input_sdk/lib/async/future.dart b/tool/input_sdk/lib/async/future.dart
index a4f8020444806fcc60f113a325afb33518170961..7d41d89adfaccbeb1a2e7ab27ca447301c4e9a22 100644
--- a/tool/input_sdk/lib/async/future.dart
+++ b/tool/input_sdk/lib/async/future.dart
@@ -254,11 +254,11 @@ abstract class Future<T> {
* The call to `cleanUp` should not throw. If it does, the error will be an
* uncaught asynchronous error.
*/
- static Future<List> wait(Iterable<Future> futures,
+ static Future<List/*<T>*/> wait/*<T>*/(Iterable<Future/*<T>*/> futures,
{bool eagerError: false,
- void cleanUp(successValue)}) {
- final _Future<List> result = new _Future<List>();
- List values; // Collects the values. Set to null on error.
+ void cleanUp(/*=T*/ successValue)}) {
+ final _Future<List/*<T>*/> result = new _Future<List/*<T>*/>();
+ List/*<T>*/ values; // Collects the values. Set to null on error.
int remaining = 0; // How many futures are we waiting for.
var error; // The first error from a future.
StackTrace stackTrace; // The stackTrace that came with the error.
@@ -312,7 +312,7 @@ abstract class Future<T> {
if (remaining == 0) {
return new Future.value(const []);
}
- values = new List(remaining);
+ values = new List/*<T>*/(remaining);
return result;
}
@@ -407,7 +407,7 @@ abstract class Future<T> {
* with a `test` parameter, instead of handling both value and error in a
* single [then] call.
*/
- Future then(onValue(T value), { Function onError });
+ Future/*<S>*/ then/*<S>*/(/*=S*/ onValue(T value), { Function onError });
/**
* Handles errors emitted by this [Future].
« no previous file with comments | « tool/analyze.sh ('k') | tool/input_sdk/lib/async/future_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698