lib/src/report.dart - Issue 1554683002: Update to latest analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/report.dart

Issue 1554683002: Update to latest analyzer (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/report.dart

diff --git a/lib/src/report.dart b/lib/src/report.dart

index 03686fdc811d3b5c98fb5c7a479de10ccff7bbdb..8c57f349f38ffd732e23d5c97dc8aa89f1c4d7a4 100644

--- a/lib/src/report.dart

+++ b/lib/src/report.dart

@@ -62,7 +62,7 @@ ErrorSeverity _strongModeErrorSeverity(AnalysisError error) {

// Upgrade analyzer warnings to errors.

// TODO(jmesserly: reconcile this with analyzer_cli

var severity = error.errorCode.errorSeverity;

- if (!error.errorCode.name.startsWith('dev_compiler.') &&

+ if (!isStrongModeError(error.errorCode) &&

severity == ErrorSeverity.WARNING) {

return ErrorSeverity.ERROR;

}

« no previous file with comments | « lib/src/compiler.dart ('k') | lib/src/server/dependency_graph.dart » ('j') | no next file with comments »