test/codegen/expect/collection/algorithms.txt - Issue 1554683002: Update to latest analyzer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/codegen/expect/collection/algorithms.txt

Issue 1554683002: Update to latest analyzer (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Messages from compiling algorithms.dart	1 // Messages from compiling algorithms.dart

2 warning: [DownCastComposite] sortedList (List<dynamic>) will need runtime check to cast to type List<Comparable<dynamic>> (package:collection/algorithms.dart, l ine 44, col 36)	2 severe: [AnalyzerMessage] sortedList (List<dynamic>) will need runtime check to cast to type List<Comparable<dynamic>> (package:collection/algorithms.dart, line 44, col 36)
	Jennifer Messerly 2016/01/04 20:48:40 is this error level still correct? it looks like w is this error level still correct? it looks like we are incorrectly promoting a Strong Mode Warning into an Error. this might be happening because of: https://github.com/dart-lang/dev_compiler/blob/9b5978cb4c89f801b781a96a8d67e3... Leaf 2016/01/04 21:34:47 Ah right. I meant to look into that, thanks for t Show quoted text On 2016/01/04 20:48:40, John Messerly wrote: > is this error level still correct? it looks like we are incorrectly promoting a > Strong Mode Warning into an Error. > > this might be happening because of: > https://github.com/dart-lang/dev_compiler/blob/9b5978cb4c89f801b781a96a8d67e3... Ah right. I meant to look into that, thanks for the pointer. Fixed now, and re-factored to avoid having to track down all the different pattern matches.
OLD	NEW