Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1552863003: Global conversion of Pass()→std::move(): CrOS edition (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
asanka, asvitkine+watch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, miu+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, rginda+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Global conversion of Pass()→std::move(): CrOS edition (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/cf738a94eb3c1ff82f1e5f8868574358a88344ec Cr-Commit-Position: refs/heads/master@{#367249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -129 lines) Patch
M chrome/browser/download/notification/download_item_notification.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/download/notification/download_item_notification_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/notification/download_notification_browsertest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/metrics/perf/perf_provider_chromeos.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/metrics/perf/perf_provider_chromeos_unittest.cc View 14 chunks +23 lines, -50 lines 0 comments Download
M chrome/browser/net/nss_context_chromeos.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_render_view_host_test_harness.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/gpu/media/vaapi_jpeg_decode_accelerator.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/media/vaapi_video_encode_accelerator.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 8 chunks +8 lines, -12 lines 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 9 chunks +10 lines, -9 lines 0 comments Download
M crypto/nss_util.cc View 9 chunks +10 lines, -8 lines 0 comments Download
M device/hid/hid_service_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/nss_cert_database_chromeos.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/cert/nss_profile_filter_chromeos.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/cert/nss_profile_filter_chromeos_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
And all the leftovers (hopefully), unless there's hidden GN targets or static library only targets ...
4 years, 11 months ago (2015-12-31 07:03:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552863003/1
4 years, 11 months ago (2015-12-31 07:03:48 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-31 07:47:37 UTC) #5
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-31 14:50:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552863003/1
4 years, 11 months ago (2015-12-31 16:03:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 16:11:53 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 16:13:46 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cf738a94eb3c1ff82f1e5f8868574358a88344ec
Cr-Commit-Position: refs/heads/master@{#367249}

Powered by Google App Engine
This is Rietveld 408576698