chrome/browser/download/notification/download_notification_browsertest.cc - Issue 1552863003: Global conversion of Pass()→std::move(): CrOS edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_notification_browsertest.cc

Issue 1552863003: Global conversion of Pass()→std::move(): CrOS edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/notification/download_item_notification_unittest.cc ('k') | chrome/browser/metrics/perf/perf_provider_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/notification/download_notification_browsertest.cc

diff --git a/chrome/browser/download/notification/download_notification_browsertest.cc b/chrome/browser/download/notification/download_notification_browsertest.cc

index 3293f97a71a27d2c02b86a94c9926cdc93a07f81..ea910c560611857596daa54d2fc0615a55bbafde 100644

--- a/chrome/browser/download/notification/download_notification_browsertest.cc

+++ b/chrome/browser/download/notification/download_notification_browsertest.cc

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include <stddef.h>

+#include <utility>

#include "base/command_line.h"

#include "base/macros.h"

@@ -338,7 +339,7 @@ class DownloadNotificationTest : public DownloadNotificationTestBase {

test_delegate->GetDownloadIdReceiverCallback().Run(

content::DownloadItem::kInvalidId + 1);

DownloadServiceFactory::GetForBrowserContext(profile)

- ->SetDownloadManagerDelegateForTesting(test_delegate.Pass());

+ ->SetDownloadManagerDelegateForTesting(std::move(test_delegate));

DownloadNotificationTestBase::SetUpOnMainThread();

}

@@ -359,7 +360,8 @@ class DownloadNotificationTest : public DownloadNotificationTestBase {

incognito_test_delegate.reset(

new TestChromeDownloadManagerDelegate(incognito_profile));

DownloadServiceFactory::GetForBrowserContext(incognito_profile)

- ->SetDownloadManagerDelegateForTesting(incognito_test_delegate.Pass());

+ ->SetDownloadManagerDelegateForTesting(

+ std::move(incognito_test_delegate));

}

TestChromeDownloadManagerDelegate* GetIncognitoDownloadManagerDelegate()