chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc - Issue 1552863003: Global conversion of Pass()→std::move(): CrOS edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

Issue 1552863003: Global conversion of Pass()→std::move(): CrOS edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc ('k') | chrome/test/base/chrome_render_view_host_test_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

index 868d216f6e9dabe7674573345c2012c5d526a657..66f10a229aadf0dfb7656acd334bdfd39d58ef6d 100644

--- a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

+++ b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

@@ -57,7 +57,7 @@ TEST_F(FileBrowserHandlerManifestTest, GetHandlersRequiresPermission) {

std::move(extensions::ListBuilder().Append("fileBrowserHandler")));

extensions::ExtensionBuilder bad_app_builder;

- bad_app_builder.SetManifest(bad_manifest_value.Pass());

+ bad_app_builder.SetManifest(std::move(bad_manifest_value));

scoped_refptr<extensions::Extension> bad_app(bad_app_builder.Build());

EXPECT_FALSE(FileBrowserHandler::GetHandlers(bad_app.get()));