content/common/gpu/media/vaapi_jpeg_decode_accelerator.cc - Issue 1552863003: Global conversion of Pass()→std::move(): CrOS edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/vaapi_jpeg_decode_accelerator.cc

Issue 1552863003: Global conversion of Pass()→std::move(): CrOS edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/desktop_capture_device_aura_unittest.cc ('k') | content/common/gpu/media/vaapi_video_encode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/vaapi_jpeg_decode_accelerator.cc

diff --git a/content/common/gpu/media/vaapi_jpeg_decode_accelerator.cc b/content/common/gpu/media/vaapi_jpeg_decode_accelerator.cc

index a9f17fe0fb4eefd4adcf513af081450176fa85bd..8efb362180dce6690939cd39fd2e8ee4c50b9664 100644

--- a/content/common/gpu/media/vaapi_jpeg_decode_accelerator.cc

+++ b/content/common/gpu/media/vaapi_jpeg_decode_accelerator.cc

@@ -6,6 +6,7 @@

#include <stddef.h>

#include <string.h>

+#include <utility>

#include "base/bind.h"

#include "base/logging.h"

@@ -79,9 +80,8 @@ VaapiJpegDecodeAccelerator::DecodeRequest::DecodeRequest(

scoped_ptr<base::SharedMemory> shm,

const scoped_refptr<media::VideoFrame>& video_frame)

: bitstream_buffer(bitstream_buffer),

- shm(shm.Pass()),

- video_frame(video_frame) {

+ shm(std::move(shm)),

+ video_frame(video_frame) {}

VaapiJpegDecodeAccelerator::DecodeRequest::~DecodeRequest() {

}

@@ -299,7 +299,7 @@ void VaapiJpegDecodeAccelerator::Decode(

}

scoped_ptr<DecodeRequest> request(

- new DecodeRequest(bitstream_buffer, shm.Pass(), video_frame));

+ new DecodeRequest(bitstream_buffer, std::move(shm), video_frame));

decoder_task_runner_->PostTask(

FROM_HERE, base::Bind(&VaapiJpegDecodeAccelerator::DecodeTask,