Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1552733002: Convert Pass()→std::move() in //content (Android edition) (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
Aaron Boodman, abarth-chromium, avayvod+watch_chromium.org, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, devtools-reviews_chromium.org, feature-media-reviews_chromium.org, jam, jochen+watch_chromium.org, mcasas+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-media_chromium.org, mlamouri+watch-content_chromium.org, nona+watch_chromium.org, Peter Beverloo, pfeldman, posciak+watch_chromium.org, qsr+mojo_chromium.org, shuchen+watch_chromium.org, James Su, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //content (Android edition) (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org Committed: https://crrev.com/a45aa7d693cd5290357ddfc9dfb122839a281079 Cr-Commit-Position: refs/heads/master@{#367130}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -63 lines) Patch
M content/browser/android/child_process_launcher_android.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/android/download_controller_android_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/android/in_process/context_provider_in_process.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/android/java/gin_java_method_invocation_helper.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/android/java/java_type.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/media/android/media_session_uma_helper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/mojo/service_registry_android.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 14 chunks +17 lines, -15 lines 0 comments Download
M content/browser/vr/android/cardboard/cardboard_vr_device.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/vr/vr_device_manager.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M content/common/android/gin_java_bridge_value.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_synchronous_compositor_android.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/renderer/media/android/media_info_loader.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/shell/browser/shell_mojo_test_utils_android.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dcheng
4 years, 11 months ago (2015-12-30 00:15:27 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552733002/1
4 years, 11 months ago (2015-12-30 00:15:57 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/139935) ios_dbg_simulator_ninja on ...
4 years, 11 months ago (2015-12-30 00:18:29 UTC) #5
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-30 00:29:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552733002/20001
4 years, 11 months ago (2015-12-30 00:53:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2015-12-30 01:56:19 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 01:57:53 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a45aa7d693cd5290357ddfc9dfb122839a281079
Cr-Commit-Position: refs/heads/master@{#367130}

Powered by Google App Engine
This is Rietveld 408576698