Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: content/browser/vr/vr_device_manager.cc

Issue 1552733002: Convert Pass()→std::move() in //content (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/vr/vr_device_manager.h" 5 #include "content/browser/vr/vr_device_manager.h"
6 6
7 #include <utility>
8
7 #include "base/bind.h" 9 #include "base/bind.h"
8 #include "base/memory/singleton.h" 10 #include "base/memory/singleton.h"
9 #include "build/build_config.h" 11 #include "build/build_config.h"
10 #include "third_party/WebKit/public/platform/modules/vr/WebVR.h" 12 #include "third_party/WebKit/public/platform/modules/vr/WebVR.h"
11 13
12 #if defined(OS_ANDROID) 14 #if defined(OS_ANDROID)
13 #include "content/browser/vr/android/cardboard/cardboard_vr_device_provider.h" 15 #include "content/browser/vr/android/cardboard/cardboard_vr_device_provider.h"
14 #endif 16 #endif
15 17
16 namespace content { 18 namespace content {
17 19
18 namespace { 20 namespace {
19 VRDeviceManager* g_vr_device_manager = nullptr; 21 VRDeviceManager* g_vr_device_manager = nullptr;
20 } 22 }
21 23
22 VRDeviceManager::VRDeviceManager() 24 VRDeviceManager::VRDeviceManager()
23 : vr_initialized_(false), keep_alive_(false) { 25 : vr_initialized_(false), keep_alive_(false) {
24 bindings_.set_connection_error_handler( 26 bindings_.set_connection_error_handler(
25 base::Bind(&VRDeviceManager::OnConnectionError, base::Unretained(this))); 27 base::Bind(&VRDeviceManager::OnConnectionError, base::Unretained(this)));
26 // Register VRDeviceProviders for the current platform 28 // Register VRDeviceProviders for the current platform
27 #if defined(OS_ANDROID) 29 #if defined(OS_ANDROID)
28 scoped_ptr<VRDeviceProvider> cardboard_provider( 30 scoped_ptr<VRDeviceProvider> cardboard_provider(
29 new CardboardVRDeviceProvider()); 31 new CardboardVRDeviceProvider());
30 RegisterProvider(cardboard_provider.Pass()); 32 RegisterProvider(std::move(cardboard_provider));
31 #endif 33 #endif
32 } 34 }
33 35
34 VRDeviceManager::VRDeviceManager(scoped_ptr<VRDeviceProvider> provider) 36 VRDeviceManager::VRDeviceManager(scoped_ptr<VRDeviceProvider> provider)
35 : vr_initialized_(false), keep_alive_(true) { 37 : vr_initialized_(false), keep_alive_(true) {
36 thread_checker_.DetachFromThread(); 38 thread_checker_.DetachFromThread();
37 RegisterProvider(provider.Pass()); 39 RegisterProvider(std::move(provider));
38 SetInstance(this); 40 SetInstance(this);
39 } 41 }
40 42
41 VRDeviceManager::~VRDeviceManager() { 43 VRDeviceManager::~VRDeviceManager() {
42 DCHECK(thread_checker_.CalledOnValidThread()); 44 DCHECK(thread_checker_.CalledOnValidThread());
43 g_vr_device_manager = nullptr; 45 g_vr_device_manager = nullptr;
44 } 46 }
45 47
46 void VRDeviceManager::BindRequest(mojo::InterfaceRequest<VRService> request) { 48 void VRDeviceManager::BindRequest(mojo::InterfaceRequest<VRService> request) {
47 VRDeviceManager* device_manager = GetInstance(); 49 VRDeviceManager* device_manager = GetInstance();
48 device_manager->bindings_.AddBinding(device_manager, request.Pass()); 50 device_manager->bindings_.AddBinding(device_manager, std::move(request));
49 } 51 }
50 52
51 void VRDeviceManager::OnConnectionError() { 53 void VRDeviceManager::OnConnectionError() {
52 DCHECK(thread_checker_.CalledOnValidThread()); 54 DCHECK(thread_checker_.CalledOnValidThread());
53 if (bindings_.empty() && !keep_alive_) { 55 if (bindings_.empty() && !keep_alive_) {
54 // Delete the device manager when it has no active connections. 56 // Delete the device manager when it has no active connections.
55 delete g_vr_device_manager; 57 delete g_vr_device_manager;
56 } 58 }
57 } 59 }
58 60
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 continue; 92 continue;
91 93
92 if (devices_.find(device->id()) == devices_.end()) 94 if (devices_.find(device->id()) == devices_.end())
93 devices_[device->id()] = device; 95 devices_[device->id()] = device;
94 96
95 VRDeviceInfoPtr vr_device_info = device->GetVRDevice(); 97 VRDeviceInfoPtr vr_device_info = device->GetVRDevice();
96 if (vr_device_info.is_null()) 98 if (vr_device_info.is_null())
97 continue; 99 continue;
98 100
99 vr_device_info->index = device->id(); 101 vr_device_info->index = device->id();
100 out_devices.push_back(vr_device_info.Pass()); 102 out_devices.push_back(std::move(vr_device_info));
101 } 103 }
102 104
103 return out_devices; 105 return out_devices;
104 } 106 }
105 107
106 VRDevice* VRDeviceManager::GetDevice(unsigned int index) { 108 VRDevice* VRDeviceManager::GetDevice(unsigned int index) {
107 DCHECK(thread_checker_.CalledOnValidThread()); 109 DCHECK(thread_checker_.CalledOnValidThread());
108 110
109 DeviceMap::iterator iter = devices_.find(index); 111 DeviceMap::iterator iter = devices_.find(index);
110 if (iter == devices_.end()) { 112 if (iter == devices_.end()) {
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 } 144 }
143 } 145 }
144 146
145 void VRDeviceManager::ResetSensor(uint32_t index) { 147 void VRDeviceManager::ResetSensor(uint32_t index) {
146 VRDevice* device = GetDevice(index); 148 VRDevice* device = GetDevice(index);
147 if (device) 149 if (device)
148 device->ResetSensor(); 150 device->ResetSensor();
149 } 151 }
150 152
151 } // namespace content 153 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/vr/android/cardboard/cardboard_vr_device.cc ('k') | content/common/android/gin_java_bridge_value.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698